Yep, looks like that was the problem. Thanks!
Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!
Quick links for Beyond New Horizons
- Download latest version
- Wiki
- FAQ
- Report bugs here
- Bug Tracker on Github
Quick links for Maelstrom
- Download the latest version of Maelstrom
- Download the latest version of ERAS II
- Download the latest version of New Horizons on Maelstrom
Quick links for PotC: New Horizons
- Download latest version
- Wiki
- FAQ
- Report bugs here
Thanks to YOUR votes, GOG.com now sells:
- Sea Dogs
- Sea Dogs: Caribbean Tales
- Sea Dogs: City of Abandoned Ships
Vote now to add Pirates of the Caribbean to the list!
Quick links for AoP2: Gentlemen of Fortune 2
- Downloads and info
- ModDB Profile
- Forums Archive
A Pirate Podcast with Interviews
Music, Comedy and all things Pirate!
- Episode Guide - About - Subscribe -
- Twitter - Facebook - iTunes - Android -
- Youtube - Fill the Coffers -
I think I found the answer in Loginterface.c. There's a XI_ConvertString that wasn't there beforeAs long as it works, I suppose...
sDateTimeDisplay = XI_ConvertString(GetDayName(GetWeekday(iday, imonth, iyear))) + ", " + GetHumanDate(iyear, imonth, iday);
Ok, I remember why I did it. The weekdays in the shiplog entries weren't translated. That's why I cut the translation string from the DateTimeDisplay and added it directly to each day in calendar.c. I think that's easier than adding the string to every entry that makes use of the weekdays, so I'll do that again.I think I found the answer in Loginterface.c. There's a XI_ConvertString that wasn't there before
Mistery solvedCode:sDateTimeDisplay = XI_ConvertString(GetDayName(GetWeekday(iday, imonth, iyear))) + ", " + GetHumanDate(iyear, imonth, iday);
EDIT: wait, maybe it was there in the first place, only I removed it to add it to each day in the calendar.c file instead for some reason. Mistery sort of solved anyway.
Brilliant! I approve of a "one size fits all" solution.Mistery definitely solved then.
case "corpse":
switch (LanguageGetLanguage()) {
case "Spanish":
curEnemyName = XI_ConvertString("s"+"captain") + " " + XI_ConvertString("Dead");
break;
// default:
curEnemyName = XI_ConvertString("Dead") + " " + XI_ConvertString("s"+"captain");
}
//Questbook
Preprocessor_AddQuestData("town",ctown.name);
Preprocessor_AddQuestData("type",XI_ConvertString("blacksmith"));
Preprocessor_AddQuestData("amount",sti(NPChar.fetch_quest.amount));
Preprocessor_AddQuestData("good",Goods[sti(NPChar.fetch_quest.good)].name);
Preprocessor_AddQuestData("money",sti(NPChar.fetch_quest.money));
Preprocessor_AddQuestData("date",NPChar.fetch_quest.expire);
GameInterface.strings.GoodsName = XI_ConvertString(Goods[GetGoodsIndexForI(nCurScrollNum)].Name);
supernice work! a herculean effortFinally, it's here!
No, not the Spanish translation but the framework to make it work, and to eventually make it easier for other translations to be implemented. This should be essentially the unfinished multilanguage support for the mod now finished, mostly I hope. There may be more translatable instances that have flown under my radar, particularly in dialog files, that I have barely touched (only the LogIt strings and a few other things I've found)
I've updated interface_strings.txt with I think over 700 lines of text that I've been hunting down across the files, I've added probably thousands of translation strings and a few Spanish-only switches for parts where the English grammar and word order doesn't fit the translation (big thanks to @Pieter Boelen , @Grey Roger and all the folks that have been dealing with my ineptitude in the translation thread). There are some unorthodox solutions and workarounds to some issues but nothing that should affect the main English version of the mod. Other things may be horribly wrong because I still don't really know very well what I'm doing when program files are concerned, but everythings seems to work fine on my end without causing errors.
I've also included my updated ShipModels_descriptions.txt with an attempt to make the descriptions more standarized and informative. I'd appreciate your opinons on that. Also in the zip is an updated ships_mames.c with revised Spanish names. I haven't included my previous revised character names because @Grey Roger had made some further edits to it so my own version is already outdated. Both the ship and character names will also need to be merged with @DeathDaisy 's Swedish names.
If you don't mind, I'll hold off adding this until the next, next update archive. I want to release the next one this week as there is already a lot of stuff waiting to be incorporated into a general release, and that translation framework involves a lot of changed files which will mean it will need a good deal of testing to make sure it doesn't break any existing gameplay. Also, some work is needed - a quick check with WinMerge shows, for example, that rank names are being translated, which they should not be as they're already in the native language of the nation which owns the ranks. It doesn't matter if you as a player speak English, Spanish or anything else; if your character has a Dutch LoM and has just been promoted to rank 7, then your rank name is "Kapitein ter Zee" because that's what Holland calls it.Finally, it's here!
No, not the Spanish translation but the framework to make it work, and to eventually make it easier for other translations to be implemented. This should be essentially the unfinished multilanguage support for the mod now finished, mostly I hope. There may be more translatable instances that have flown under my radar, particularly in dialog files, that I have barely touched (only the LogIt strings and a few other things I've found)
Id guess hawk have two entries in character_names.txt then? so the one that comes first is hawk from nathaniel hawk and the translated comes next? idk if thats the case, but if it is maybe soaring hawks last name in ardent/characters/tempquest.c could be turned into an xi_convertstring instead of a translatestring and hawk put into the spanish common.ini. dunno if that would work, but perhaps worth a try?Hmm, playtesting the pronouns in Ardent's storyline I came across the Taino chief and his "lastname" isn't translated, when all the other indians are fully translated. The files seem to be 100% right. I wonder if it'll have something to do with the fact that the chief's name is Soaring Hawk, and the game is somehow confusing it with the last name of our own and only Nathaniel Hawk from the standard storyline, who of course doesn't have a translation associated to it. Any thought, @Grey Roger ?
That shouldn't be the case, as the Ardent storyline has its own character_names.txt separate from the main one, although it may be that the main one overwrites the other somehow if the same name is repeated.Id guess hawk have two entries in character_names.txt then?
That or directly changing Hawk for a placeholder in tempquest.c (like "Hawk1" or whatever) and then translating that in both the English and Spanish character_names files for Hawk and the corresponding Spanish. From my limited knowledge, I personally prefer this option because it seems to me it would be easier to track down later and recognize why it was done in the first place.maybe soaring hawks last name in ardent/characters/tempquest.c could be turned into an xi_convertstring instead of a translatestring and hawk put into the spanish common.ini. dunno if that would work, but perhaps worth a try?