• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Included in Build Ship Encounter Chances Correction

Here's one of them WEIRD encounters:
Code: 
Fantom_GenerateEncounter: type = Merchant 2, # Mer = 1, Mer MAX = 0, Mer MIN = 0, # War = 1, War MAX = 3, War MIN = 5
ERROR - Force_GetShipType: unable to find ship, returning a default ship instead
ERROR - Force_GetShipType: Maxclass = 3, Minclass = 3, Per = Colonial Powers, Nat = Pirate, Type = Trade
Force_GetShipType: Maxclass = 3, Minclass = 5, Per = Colonial Powers, Nat = Pirate, Type = War, Loop = 0, Ship ID = PiratFrigateSup
Compares to this encounter init entry:
Code: 
        makeref(rEnc, EncountersTypes[ENCOUNTER_TYPE_MERCHANT2]);    // 1 + 3
        n++; rEnc.Skip = false;
        rEnc.Type = ENCOUNTER_TRADE;
        rEnc.MinRank = 4;
        Enc_AddShips(rEnc, "Trade", 1, 1);
        Enc_AddShips(rEnc, "War", 2, 3);
        Enc_ExcludeNation(rEnc, PIRATE);
 
        Enc_AddClasses(rEnc, 4, 4, 5, 3, 5);
        Enc_AddClasses(rEnc, 5, 4, 5, 3, 5);
        Enc_AddClasses(rEnc, 6, 3, 5, 2, 5);
        Enc_AddClasses(rEnc, 7, 3, 5, 2, 5);
        Enc_AddClasses(rEnc, 8, 3, 5, 2, 4);
        Enc_AddClasses(rEnc, 9, 3, 5, 2, 4);
        Enc_AddClasses(rEnc, 10,3, 5, 2, 4);
        Enc_AddClasses(rEnc, -1,3, 4, 2, 4); // NK for shipcap off
So the game is asking for:
1 war ship between classes 3 and 5: returns the Tier 5 "PiratFrigateSup", which is fair enough
1 merchant ship between classes 0 and 0 (???): ends up asking for a class 3 one instead. UH???

Also, why are there even pirate merchant encounters in the first place? DESPITE that Enc_ExcludeNation line???

I'm confused. o_O
 
OK, that's just weird. :facepalm
We give the game these parameters to work with, and it just goes "Nope! I want to do THIS instead."

Isn't it supposed to generate either 2 or 3 naval ships for that encounter, not just one?

Pieter Boelen said:
1 war ship between classes 3 and 5: returns the Tier 5 "PiratFrigateSup", which is fair enough
Click to expand...
That ship is (should be) Tier 4... makes no difference, though.
 
I do believe you're right! So where's that second one then?
We know this is not an isolated pirate issue though; I've seen a Dutch version too.

Armada said:
That ship is (should be) Tier 4... makes no difference, though.
Click to expand...
That's what I get for looking at the ships_init.c entry. :facepalm
 
Are there no class 4 pirate war ships in the Napoleonic time period???
That's what my rewritten GenerateQuestShip code claims. :shock
 
Pieter Boelen said:
Are there no class 4 pirate war ships in the Napoleonic time period???
That's what my rewritten GenerateQuestShip code claims. :shock
Click to expand...

Yep. The PiratCorvette and CrimsonBlood are only set for periods 3 and 4, and PiratFrigateSup is in periods 2 and 3.
None of them really work in a Napoleonic setting, and we don't have any equivalents in use by the pirates.
In some ways, this sort of reflects the decline in piracy by that time. And pirates using frigates is unrealistic, anyway.
 
Oh well, at least that's intentional then. Originally I had written my new quest ship selection code to use only ONE class of ships.
Since the max class for pirates is 4, that means the game HAD to find a class 4 pirate ship.
Which never happened, so we got our famous error message and a default random ship being used instead.

The error went away though since I loosened up the min class requirement to be 1 more than the max class.
Now at best, a pirate ship will be selected between class 4 and class 5, which does work.
So the end result of my code should be fair enough then for pirates. Thanks for confirming! :woot
 
Armada, what are the largest trade ships available in the Napoleonic time period?
I keep getting errors on the escort quests that the game can't find a ship. :facepalm
 
Erm, that's probably the Fast Merchantman. We added those back to the Napoleonic period after noticing that there were no equivalents in the period.
It's a shame really; I'd like to see something Amsterdam-sized in that period, but we don't have any Napoleonic versions of that.
 
I "solved" it by letting the ships to be escorted be anywhere between Tier 7 and whatever max class the game would like.
So that opens up the range and should allow ships to be selected properly. And why couldn't a ship to be escorted be smaller anyway?
That's probably WHY they'd want to be escorted in the first place! :whipa
 
I captured Manowar when i was lvl 15 there were french vs pirates and there was a lot of french battleships huge convoy and at the end of convoy there was Manowar or 1st Rate Ship of the Line his name was Gustav lol. I had Heavy Pinnace of War with full crew he had like half of them when i boarded there was no fight just their captain standing i told him do u wana be my officer he said yes lol :) . And i remember how hard was to take Manowar from Silehard with 700 crew Battleship this was too easy.
 
My update to the Select Storylines interface is showing a lot of interesting things:
http://www.piratesahoy.net/threads/...-code-and-much-more.20575/page-16#post-458549

For example, there are no Tier 1 ships in Early Explorers. The only one that shows up is the PO_Trinity, which is a Vanderdecken-only ship. *
The only Tier 2 ship is the Heavy War Galleon for Spain.

The Fluyt-of-War with Dutch colours is available also for Spain and Portugal.
However, both those nations do have other Tier 3 ships available, but Holland does not.

* = Edit: I'm adding period chance values to the PO_Trinity so she won't show up in Select Storyline at all, except where appropriate.
Even if she's a Vanderdecken ship. Makes it much clearer that she is NOT available for quest use and such.
 
Last edited:
Now here is something odd:
DutchOrGerman.jpg
So is she DUTCH or GERMAN? :rofl
Seriously though, is that the type name we want?
 
Well what do you expect us to do about the lack of Tier 1 and 2 ships in Early Explorers? Make the Tier system period-specific? Maybe not the best idea. :nerbz
We've had plenty of time to analyse the ups and downs of the system by now.

The Fluyt-of-War thing can easily be changed. Makes no difference to me.
 
Armada said:
Well what do you expect us to do about the lack of Tier 1 and 2 ships in Early Explorers? Make the Tier system period-specific? Maybe not the best idea. :nerbz
We've had plenty of time to analyse the ups and downs of the system by now.
Click to expand...
It was just an observation. I've got no problem with it. :no
 
The Spanish Heavy War Galleon was a tier 1 ship in 1570 when she was built. As part of the Spanish Armada the English considered her unsinkable.

That looks like the FWzP, built in, umm, either 1625 or 1640. She was a Dutch ship that was classified as a frigate at the time. The definition of frigate changed over the centuries. The FWzP escorted the fleut Derfflinger to the Dutch East Indies and on another voyage that way was intercepted by three French warships and burned in the battle. I dunno how the Germans got involved...........
 
Pieter Boelen said:
You want all ships you encounter to be the same class as your own? Do you have Beta 2.5 yet?
Go into the Options>Difficulty menu on your savegame, then click the "[Player] will be notified of all sightings".
It should change to "[Player] won't be notified of too-powerful sightings". That will make the ships you encounter be based on your own class.
So if you've got a small ship, you'll only encounter small ones. But if you've got a big one, you'll be encountering big ones.
Click to expand...

I gave myself a 1st rate with the console in 2.5 . It's only sloops, pirate schooners /not pirate owned/ and kreyser frigates, even if there are 10 ships to meet all are among these, for warships. Met also of the older type schooners. Changed the difficulty to "[Player] won't be notified of too-powerful sightings" NO RESULT I am afraid. In the Jack Sparrow storyline. Any updates or ideas ?

p.s. Tried also with FWzP - same, only kreyser frigates and sloops everywhere.
 
Hylie Pistof said:
The Spanish Heavy War Galleon was a tier 1 ship in 1570 when she was built. As part of the Spanish Armada the English considered her unsinkable.
Click to expand...
She would have been one of the most powerful of her time, yes. The problem is, we can't take that into account with our gameplay-oriented Tier system unless we make it a period-dependent system. This would bring us back to the idea of using historical rating systems again, which we decided before wasn't ideal for gameplay, not least because it doesn't work for merchant vessels.

Hylie Pistof said:
That looks like the FWzP, built in, umm, either 1625 or 1640. She was a Dutch ship that was classified as a frigate at the time. The definition of frigate changed over the centuries. The FWzP escorted the fleut Derfflinger to the Dutch East Indies and on another voyage that way was intercepted by three French warships and burned in the battle. I dunno how the Germans got involved...........
Click to expand...
As MK said elsewhere:
modernknight1 said:
Although to be more precise, she was a German (Brandenburg) "Frigate" built in the Dutch style (Dutch 3rd rate) by Dutch shipwrights.
Click to expand...
It's this ship he's referring to: http://de.wikipedia.org/wiki/Friedrich_Wilhelm_zu_Pferde
 
How about changing her type name to Brandenburg Frigate? Makes more sense to me than "Dutch-built Frigate".

Armada said:
She would have been one of the most powerful of her time, yes. The problem is, we can't take that into account with our gameplay-oriented Tier system unless we make it a period-dependent system. This would bring us back to the idea of using historical rating systems again, which we decided before wasn't ideal for gameplay, not least because it doesn't work for merchant vessels.
Click to expand...
What we've got now is good enough as far as I'm concerned. Simple, easy to remember.
 
You must log in or register to reply here.
Back
Top