I tried it last night in a short storm with the Indiaman, which is a stripped down light frigate, and that change slowed it down quite a bit. The same tendency to turn sideways to the waves and just sit there followed by a hard turn is still there, it just happens much slower.
yeah i've tested our spin left bug fix and it is still not fixed really, maybe it happens less often(maybe?) but it still will get into a spin to the left. I've gone back to the original blundering in the dark fix which was:
Code:
case 0: arCharShip.stormimp = fRotate; fRotate = 0.01; break;
case 1: arCharShip.stormimp = fRotate; fRotate = - 0.01; break;
As that was modeled on the commented out code at the top of this section:
Code:
if (fRotate > 0.07) { fRotate = 0.07; }
if (fRotate < -0.07) { fRotate = -0.07; }*/
In my original testing for this problem it seemed to give the best overall results re the spin left bug, although i haven't been able to test it more recently, but will let people know how it goes once i get around to it.
RE: "Baste's critical hit code is in PROGRAM\Loc_ai\LAi_fightparams.c"
I've had some good success and managed to 'meld'(as in the vulcan mind-meld) the old file with the new one so i no longer have really tough melee battles that often see enemy npc's doing massive damage through blocks and killing me and my officers etc.
I'll post the file here and someone who knows code could look through it etc. I'd be in favour of incorporating Bastes new critical hit calculation damage code he posted above on this(i haven't done that yet as i've just been making certain combats have returned to pre-patch 7 wip 2 levels(which they have in this file) as well, or atleast testing it out etc.
In other annoying news i've been attempting to use my initItems.c file values in the new patch 7 format, again 'melding' the values into the current patch 7 files and after tracking down a few errors associated with weapon nationality names('ENGLISH' where it should be 'ENGLAND' etc - all my fault!) i'm still getting error remarks like this that i'm not sure about what might be causing them:
From 'error.log':
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 573
missed attribute: model
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 573
no rAP data
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 22
missed attribute: model
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 22
no rAP data
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 26
missed attribute: model
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 26
no rAP data
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 26
missed attribute: model
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 26
no rAP data
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 32
missed attribute: model
RUNTIME ERROR - file: ITEMS\itemLogic.c; line: 32
no rAP data
RUNTIME ERROR - file: ITEMS\items_utilite.c; line: 1699
missed attribute: skipgeneral
RUNTIME ERROR - file: ITEMS\items_utilite.c; line: 1699
no rAP data
RUNTIME ERROR - file: ITEMS\items_utilite.c; line: 1699
missed attribute: skipgeneral
RUNTIME ERROR - file: ITEMS\items_utilite.c; line: 1699
no rAP data
RUNTIME ERROR - file: quests\quests.c; line: 414
invalid index -1 [size:2250]
RUNTIME ERROR - file: quests\quests.c; line: 414
function 'CharacterFromID' stack error
RUNTIME ERROR - file: quests\quests.c; line: 414
invalid index -1 [size:2250]
RUNTIME ERROR - file: quests\quests.c; line: 414
function 'CharacterFromID' stack error
RUNTIME ERROR - file: quests\quests_common.c; line: 1475
Using reference variable without initializing
RUNTIME ERROR - file: quests\quests_common.c; line: 1475
uninitialized function argument
RUNTIME ERROR - file: quests\quests_common.c; line: 1475
function 'LAi_GetCharacterHP' stack error
RUNTIME ERROR - file: quests\quests_common.c; line: 1475
Using reference variable without initializing
RUNTIME ERROR - file: quests\quests_common.c; line: 1475
Using reference variable without initializing
RUNTIME ERROR - file: quests\quests_common.c; line: 1475
uninitialized function argument
RUNTIME ERROR - file: quests\quests_common.c; line: 1475
function 'LAi_SetCheckMinHP' stack error
RUNTIME ERROR - file: quests\quests.c; line: 414
invalid index -1 [size:2250]
RUNTIME ERROR - file: quests\quests.c; line: 414
function 'CharacterFromID' stack error
RUNTIME ERROR - file: quests\quests_common.c; line: 1525
Using reference variable without initializing
RUNTIME ERROR - file: quests\quests_common.c; line: 1525
uninitialized function argument
RUNTIME ERROR - file: quests\quests_common.c; line: 1525
function 'LAi_RemoveCheckMinHP' stack error
RUNTIME ERROR - file: quests\quests.c; line: 414
invalid index -1 [size:2250]
RUNTIME ERROR - file: quests\quests.c; line: 414
function 'CharacterFromID' stack error
RUNTIME ERROR - file: quests\quests_common.c; line: 1530
Using reference variable without initializing
RUNTIME ERROR - file: quests\quests_common.c; line: 1530
uninitialized function argument
RUNTIME ERROR - file: quests\quests_common.c; line: 1530
function 'LAi_type_actor_Reset' stack error
RUNTIME ERROR - file: quests\quests.c; line: 414
invalid index -1 [size:2250]
RUNTIME ERROR - file: quests\quests.c; line: 414
function 'CharacterFromID' stack error
RUNTIME ERROR - file: quests\quests_common.c; line: 1535
Using reference variable without initializing
RUNTIME ERROR - file: quests\quests_common.c; line: 1535
uninitialized function argument
RUNTIME ERROR - file: quests\quests_common.c; line: 1535
function 'LAi_SetWarriorTypeNoGroup' stack error
RUNTIME ERROR - file: quests\quests.c; line: 414
invalid index -1 [size:2250]
RUNTIME ERROR - file: quests\quests.c; line: 414
function 'CharacterFromID' stack error
RUNTIME ERROR - file: quests\quests_common.c; line: 1540
Using reference variable without initializing
RUNTIME ERROR - file: quests\quests_common.c; line: 1540
uninitialized function argument
RUNTIME ERROR - file: quests\quests_common.c; line: 1540
function 'LAi_group_MoveCharacter' stack error
RUNTIME ERROR - file: ITEMS\items_utilite.c; line: 1699
missed attribute: skipgeneral
RUNTIME ERROR - file: ITEMS\items_utilite.c; line: 1699
no rAP data
Now the itemLogic errors are probably to do with the changes to initItems.c, but i'm not sure why i now have quest errors? Did new quest stuff get added in this last patch 7 and if so are others getting these messages in their error.log?