Sorry, I misunderstood. I thought it was only legal to sink a ship if you had a LoM and were flying the appropriate flag, so it was piracy if you are flying Personal flag when you fight a ship belonging to the LoM nation's enemy.
That would indeed be a bit TOO harsh. Thankfully that isn't the case though.
I've had a look through 'UpdateRMRelation' and have (I hope!) a better idea of how it works.
It seems to be impossible to be in service of a nation except by being professional navy or having a LoM.
True.
So would a French merchant sailor be in service of Personal?
The function technically would return UNKNOWN_NATION, which is another way of saying "not officially in the service of ANY nation".
For figuring out whether a fight is self defence or piracy, I'm trying to work out how to distinguish between someone who is playing, say, a French non-military character, flies a French flag routinely, and defends himself against an attacking British ship; versus someone who is playing, say, a Dutch non-military character, encounters a British ship, wants to attack it so hoists a French flag to provoke it into attacking him. The former would be self-defence, the latter would be piracy because the British ship was peaceful to the player until he provoked it.
Maybe a very simple one could be to check:
- If the ship belongs to a nation that is hostile to you personally
AND
- You are flying either your Served Nation OR your Personal flag
But of course that would end up covering almost EVERY conceivable situation. The only exceptions being:
- You are attacking a ship of a nation that isn't actually hostile to you at all (EVIL!!!)
- You were flying a still-hostile-but-not-your-own flag (whoever is going to do
that?)
So the end result would be that effectively the whole "potential for piracy" system gets killed.
Which, to me, seems like a
loss in functionality rather than an improvement.
I quite like the current system: If you don't get better (because you just escaped or didn't capture the ship), then it isn't an act of piracy and it is OK.
As soon as you gain an advantage, either because you could pick up the cargo of the ship you sank or because you captured that ship, then it IS piracy. Even so, it is only
minor piracy.
The game is really quite forgiving in that respect and you need to keep up that behaviour for quite some time AND not compensate to actually notice any ill effects of that.
So for now, I stand by my original decision that it is quite fine as-is.
Eventually, once I rewrite it to check the disadvantaged party, I want to take
@Flannery's suggestion so that all the nation relation effects are SKIPPED if you kill all survivors.
No survivors means no witnesses and no witnesses means no consequences.