• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Pre Build 13 Modpack

About the automatic equipping og guns. The idea was this:

When your´re running out of ammo, your gun is unequipped. (An easy way to unable more shots)
Now if you get new ammo your gun should be auto-equipped. (For convenience & "shooting possible")

If you carry more than one gun, I sort of ranked the guns and the "best" one (with appropriate ammo) should be the one equipped. I´m sorry if there are any "wrong" choices. I think it´s still possible to manually change gun. I´ll see to it....
 
Pieter, anyone..., that LoM bug has to be fixed, and soon else there won't be much point in the game.
From what I see, once you get the LoM for all nations (bug) then nothing else happens.

Six sunken pirate ships later and my score with pirates has gone from -60 to -66 but the scores of zero and one remain the same for all other countries! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />
 
I was planning on writing here that I don't know how the bug is caused, but after doing a bit of research in the code, I think I DO know how the LoM bug is caused. It is the attempted fix for the Hoist Flag mod. I dare say that you get a LoM after you go to map sailingmode either the first or the second time? I think I see how it should be fixed. I put some code at the wrong place. It is only being run when you hoist the flag, while it should always be run. Let's see if changing that does some good.

BTW: While we're at it: What new bugs really do need fixing? For all I know, this is the only bug that badly needed fixing. For all I know, the rest of the new stuff should works reasonably well.

I have made a small update which I will be uploading in a few minutes. Stuff changed: LoM bug hopefully fixed, Black Pearl made boardable (don't know if doing that is a good idea) and, at the request of Petros, the Weathered Schooner now has 9lb guns. Also: Somebody said that the fearless, warship1 and warship2 should have 44 guns each instead of 40. Is that indeed so? if so, I'll change it next time.
<!--coloro:#FF0000--><span style="color:#FF0000"><!--/coloro-->Edit:<!--colorc--></span><!--/colorc--> Update available <a href="http://pieter.piratesahoy.net/downloads/small_update.zip" target="_blank">here</a>. Please tell me if that fixes the LoM bug. I tried replicating the bug, but didn't see it happen myself, for some crazy reason. Still, I reckon this ought to fix it.
 
<!--quoteo(post=135433:date=Nov 22 2005, 09:39 PM:name=giuliootto)--><div class='quotetop'>QUOTE(giuliootto @ Nov 22 2005, 09:39 PM) [snapback]135433[/snapback]</div><div class='quotemain'><!--quotec-->I've CORPSEMODE=1, How can I turn on error loggin and where can I retrieve the error log?<!--QuoteEnd--></div><!--QuoteEEnd-->
Woops. Forgot to answer this question. Use the PotC modhelper in the /tools subfolder, point it to your PotC installation and set "Enable this if you want to generate error reports" on (Settings tab). Then click "Save settings". Then when the game is played, the errors will be reported in a file named "error" in your main PotC folder.
 
Pieter, <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" />

The LoM fix doesn't let the game start. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" />
 
<!--quoteo(post=135599:date=Nov 28 2005, 08:12 AM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Nov 28 2005, 08:12 AM) [snapback]135599[/snapback]</div><div class='quotemain'><!--quotec-->...I think I DO know how the LoM bug is caused. It is the attempted fix for the Hoist Flag mod.<!--QuoteEnd--></div><!--QuoteEEnd-->

Well, as the bug fix didn't let the game start, I just reinserted the Nov 22 Post B12 mods "battleinterface.c" file and then removed the Mad-h code.

Now the game works and the LoM problem is solved.

Starting a new game, the Pirate mission problem is solved as well.
 
Petros, in the small update that pieter made today, you can find in the battleinterface.c this section of code 2 times in the file :

// --> Hoist the flag code fix by Mad-h
int franciarel = (GetRMRelation(GetMainCharacter(),FRANCE));
int spanyolrel = (GetRMRelation(GetMainCharacter(),SPAIN));
int portugalrel = (GetRMRelation(GetMainCharacter(),PORTUGAL));
int hollandrel = (GetRMRelation(GetMainCharacter(),HOLLAND));
int angolrel = (GetRMRelation(GetMainCharacter(),ENGLAND));

The variable declaration is duplicated so you just have to delete the "int" for each line in the last (second) block like this one above and the game will start again.

Cheers <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" />
 
Woops. That was rather stupid of me. I thought I started the game using the small update, but I must not have remembered correctly. Sorry for the trouble. The small update has been fixed now. The code that should be in there was in there twice instead of once. I reckon it <i>should</i> work now.
 
<!--quoteo(post=135646:date=Nov 29 2005, 09:19 AM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Nov 29 2005, 09:19 AM) [snapback]135646[/snapback]</div><div class='quotemain'><!--quotec-->Woops. That was rather stupid of me. I thought I started the game using the small update, but I must not have remembered correctly. Sorry for the trouble. The small update has been fixed now. The code that should be in there was in there twice instead of once. I reckon it <i>should</i> work now.<!--QuoteEnd--></div><!--QuoteEEnd-->

Downloaded and installed your new fix.

The LoM bug still exists!

a. On a saved game it resets all LoM to zero and Pirate hunting missions don't work.

b. In a new game, it still assigns LoM for all nations.
Pirate hunting missions do work.
You probably can't get promoted however, as the LoMs keep being reset to zero!

I'm going back to my fix (described 3 posts above) which works fine for me.
I'll pass the baton to someone else to keep testing LoM bug fixes!
 
Does anyone know what Mad-h wanted to fix with that? (Mad-h, still around? )


If I understand the code right this section
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->    switch(commandName)
    {
    // Hoist Flag MOD -Amokachi
    case "BI_HoistFlag":
....
        // --> Hoist the flag code fix by Mad-h
        int franciarel = (GetRMRelation(GetMainCharacter(),FRANCE));
        int spanyolrel = (GetRMRelation(GetMainCharacter(),SPAIN));
        int portugalrel = (GetRMRelation(GetMainCharacter(),PORTUGAL));
        int hollandrel = (GetRMRelation(GetMainCharacter(),HOLLAND));
        int angolrel = (GetRMRelation(GetMainCharacter(),ENGLAND));<!--c2--></div><!--ec2-->stores as "franciarel" etc. the relations you have with each nation at the time when you press the "Hoist flag" button. (Pieter, if you move that section to the beginning of the file it will FAIK only store the relationdata at the point when the programcode is being built up)

This section is SUPPOSED to restore those old "before hoisting" relations whenever you enter the map
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->    case "BI_Map":

        // --> Hoist the flag code fix by Mad-h
        SetRMRelation(GetMainCharacter(), FRANCE, franciarel);
        SetRMRelation(GetMainCharacter(), SPAIN, spanyolrel);
        SetRMRelation(GetMainCharacter(), PORTUGAL, portugalrel);
        SetRMRelation(GetMainCharacter(), HOLLAND, hollandrel);
        SetRMRelation(GetMainCharacter(), ENGLAND, angolrel);
        UpdateRelations();
        RefreshBattleInterface();
        // <-- Hoist the flag code fix by Mad-h

        Sea_MapLoad();
        break;<!--c2--></div><!--ec2-->But if you have never used "hoist flag" there are no data for those "old relation" variables, and I assume that the program then simply takes the values 0 or 1, which are the values for LOM relations.

So some major rewriting seems necessary to check if you have ever used "hoist flag" before you enter the map. But unless Mad-h or someone else can explain what this relationstoring is supposed to do I don't see much point in that. For the time being I'd follow Petro's advice and disable those sections.
 
<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" /> CCC

This is the thread that explains what is being attempted with "Hoist the Flag"
<a href="http://forum.piratesahoy.net/index.php?showtopic=6280" target="_blank">http://forum.piratesahoy.net/index.php?showtopic=6280</a>
 
Is there some code there then that <i>is</i> being run every time you enter sea-mode? I tried something again and updated the <a href="http://pieter.piratesahoy.net/downloads/small_update.zip" target="_blank">small update</a> again. Does this fix it or does it still not work? <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
<!--quoteo(post=135699:date=Nov 30 2005, 02:04 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Nov 30 2005, 02:04 PM) [snapback]135699[/snapback]</div><div class='quotemain'><!--quotec-->Is there some code there then that <i>is</i> being run every time you enter sea-mode? I tried something again and updated the <a href="http://pieter.piratesahoy.net/downloads/small_update.zip" target="_blank">small update</a> again. Does this fix it or does it still not work? <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" /><!--QuoteEnd--></div><!--QuoteEEnd-->
You tell us, did it work for you? <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/razz.gif" style="vertical-align:middle" emoid=":razz" border="0" alt="razz.gif" />
 
I don't know. I never saw the bug for myself, so I can't tell if it works or not. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />
 
<!--quoteo(post=135730:date=Dec 1 2005, 10:20 AM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Dec 1 2005, 10:20 AM) [snapback]135730[/snapback]</div><div class='quotemain'><!--quotec-->I don't know. I never saw the bug for myself, so I can't tell if it works or not. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" /><!--QuoteEnd--></div><!--QuoteEEnd-->

Hello Pieter,

I've installed your last small update this morning and i can say that the LOM 's bug is removed but we can't do pirate hunting missions..
 
Is the "can't do pirate hunting missions"-bug introduced in the latest modpack version or was it already in there? I don't think what caused the LoM bug would have caused that bug as well, so I don't know how or why the bug got in there. For all I know, pirate hunting missions have been buggy for months. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
<!--quoteo(post=135735:date=Dec 1 2005, 11:34 AM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Dec 1 2005, 11:34 AM) [snapback]135735[/snapback]</div><div class='quotemain'><!--quotec-->Is the "can't do pirate hunting missions"-bug introduced in the latest modpack version or was it already in there? I don't think what caused the LoM bug would have caused that bug as well, so I don't know how or why the bug got in there. For all I know, pirate hunting missions have been buggy for months. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" /><!--QuoteEnd--></div><!--QuoteEEnd-->

I'm sorry Pieter. I have to add something else... With a new game, we can do pirate hunting missions .. but if i play with an old save i can't...
 
I'm sorry for that. Since I am no great coder, a new game is required with almost every new update. Sometimes even when it's a ruddy bloody small one like the latest one. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
You must log in or register to reply here.
Back
Top