• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Apothecary Mod changes

S

Swindler

Landlubber
Storm Modder
<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" />

Having Alan Smithees kind permssion, I want to make my slight changes to his apothecary mod available to the community.

It gives you the possibility, also to increase max hp of your officers (although max hp of officers are increased just by 2, not 5). There's still the small "bug", that an officer, that has more hp than normal for his level (e. g. Fred Bob) will fall back to default hp's of his level. I think, that's caused by the function ResetHP(), but I don't know, if that's wanted or not.

The mod is on public ftp. Tested on top of the most recent Post Build 12 Pack with new islands also.

Cheers!
 
It should be possible to set a HP bonus for characters like Fred Bob using a line of code like this: ChangeHPBonus(&PChar, 5); . Of course this line would add a HP bonus of 5 to the player character, so you'd have to change the line to work on Fred Bob instead. And set the 5 to amount of additional HP he's supposed to have. Even if the HP is reset, the bonus will still be taken into account. I think... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />

Thanks for making this mod, BTW. I'll put it into the modpack version I'm working on right now. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />
 
<!--QuoteBegin-Pieter Boelen+Oct 2 2005, 12:23 PM--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 2 2005, 12:23 PM)</div><div class='quotemain'><!--QuoteEBegin-->It should be possible to set a HP bonus for characters like Fred Bob using a line of code like this: ChangeHPBonus(&PChar, 5); . Of course this line would add a HP bonus of 5 to the player character, so you'd have to change the line to work on Fred Bob instead. And set the 5 to amount of additional HP he's supposed to have. Even if the HP is reset, the bonus will still be taken into account. I think... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
<div align="right">[snapback]131636[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->

Hmm... I don't think so... We call ChangeHPBonus() and then ResetHP(). I took a look at the code of the second function and that does some arithmetic, calculating max hp on the level of the officer. The same happens when Fred Bob levels up for the first time. Has nobody noticed this yet?

<!--quoteo--><div class='quotetop'>QUOTE</div><div class='quotemain'><!--quotec-->Thanks for making this mod, BTW. I'll put it into the modpack version I'm working on right now. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />
<div align="right">[snapback]131636[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->

As Capitan Hawk would say: "You flatter me!" Anyway: your putting together the mods to a pack is really, really great work! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/wavarr.gif" style="vertical-align:middle" emoid=":warr" border="0" alt="wavarr.gif" />
 
For all I know, the ChangeHPBonus() code was added to the game to make sure the bonus won't be reset when you level up. When you get a HP bonus from the apothecary, it should stay in effect for the entire game. However, Fred Bob doesn't have a HP bonus set yet. So the first time his HP is being reset, he loses the bonus. So if you give him the HP bonus before he is reset, the HP bonus should stay in effect. You might want to try it out. It should work for all I know, but I don't know if it will... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
You find me confused <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />

I mean, when you hire Fred Bob, he has 280 max hp. When he first levels up, his hp's are changed to 98. Is that supposed to be?

The same happens when you hire him, go to the apothecary straight away and give him the treatment: afterwards his hps are 98.

Cheers!
 
For all I know, that's not what is supposed to happen, but that is what the code will let happen. Apparently 98 hp is the normal amount of hp for his level, so the next time a hp reset is performed on him (such as on a level up or at the apothecary's), his hp is set to the default, then increased to the new level. In the case of the apothecary, his hp bonus is increased with 2. So what you should do is to give him a hp bonus of 280-98=182 by default. He should keep that bonus all through the game. I hope... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
<!--QuoteBegin-Swindler+Oct 3 2005, 03:56 AM--><div class='quotetop'>QUOTE(Swindler @ Oct 3 2005, 03:56 AM)</div><div class='quotemain'><!--QuoteEBegin-->You find me confused  <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />

I mean, when you hire Fred Bob, he has 280 max hp. When he first levels up, his hp's are changed to 98. Is that supposed to be?

The same happens when you hire him, go to the apothecary straight away and give him the treatment: afterwards his hps are 98.

Cheers!
<div align="right">[snapback]131707[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->

<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" /> Swindler and Pieter

That is not, nor was it ever, supposed to happen, and at one time it didn't happen so it most definitely is a bug!

Many if not most of the "tavern/street hire" officers come with more HP than the level1=45, level2=50, etc. that the player is locked into at the start of the game.

If all these officers get reset to the values of the player, then the game is ruined!
If you're at level 20 or so, and playing on Swashbuckler level, you face enemy with HP in the 500 - 1000 range, and your officers are toast!

NK wrote code that temporarily changed HP for player and officers during boarding based on morale, crew strength etc. and resets the values once the battle is over. Perhaps this code has been lost/damaged.
 
<!--QuoteBegin-Pieter Boelen+Oct 3 2005, 05:28 AM--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 3 2005, 05:28 AM)</div><div class='quotemain'><!--QuoteEBegin-->For all I know, that's not what is supposed to happen, but that is what the code will let happen. Apparently 98 hp is the normal amount of hp for his level, ...<div align="right">[snapback]131708[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->

The code is only allowing it to happen because it is bugged!
This did not happen in Build 12!

We must refrain from writing new mods to work around bugged code.

The bugs need to be fixed first, or else nothing that comes after will work properly.

That is why the call to stop new additions was made.
 
But we can't fix much bugs without good bugfixers (a.k.a. Nathan Kell). <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/ib012.gif" style="vertical-align:middle" emoid=":cry" border="0" alt="ib012.gif" />
 
<!--QuoteBegin-Petros+Oct 3 2005, 07:27 PM--><div class='quotetop'>QUOTE(Petros @ Oct 3 2005, 07:27 PM)</div><div class='quotemain'><!--QuoteEBegin-->NK wrote code that temporarily changed HP for player and officers during boarding based on morale, crew strength etc. and resets the values once the battle is over. Perhaps this code has been lost/damaged.
<div align="right">[snapback]131726[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->

I think, that's the cause: I stated already, that some arithmetic is done in the ResetHP() function, Alan uses in the apothecary mod. But I didn't dare to fix it, because I also read, that this is used for this boarding stuff. And what's going on at sea is beyond my knowledge, landlubber that I am <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/smile.gif" style="vertical-align:middle" emoid=":)" border="0" alt="smile.gif" />

I can fix problems with quests, etc. where already written functions can be used or attributes of locations have to be set (as I did with the Claire Larrouse quest). But my knowledge of C is not good enough that I dare to touch the functions themselves now.
<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />
 
Hey quick note... I finally got the internet at home, a relatively fast wireless connection, so I can d/l Pieter's latest modpack, finally, and some othe other new stuff, and maybe try and get back into modding when time between homework allows.

I'm trying to find that game someone mentioned on the forums a few months ago, I forget the name of it but it has the same file format as PotC so I wanted to try it. It's some German/Chinese game and you can download the whole thing online but it's a friggin' huge file. Anyone remember the name of it or where it's at?
 
<!--QuoteBegin-Pieter Boelen+Oct 3 2005, 07:13 PM--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 3 2005, 07:13 PM)</div><div class='quotemain'><!--QuoteEBegin-->But we can't fix much bugs without good bugfixers (a.k.a. Nathan Kell). <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/ib012.gif" style="vertical-align:middle" emoid=":cry" border="0" alt="ib012.gif" />
<div align="right">[snapback]131729[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->
I don't think we should expect Nathan to fix all the bugs that we have created. For sure, he is a coding genius and most helpful and supportive (without him I wouldn't be here). But lately he hasn't time enough even for his OWN mods, and debugging OTHER people's code is a difficult and unrewarding task. No, IMHO only one person has the prime responsibility for debugging a mod: the author himself.

He knows best what he he has changed and the reasoning behind it, so for him it's much easier to find what could be wrong. Often the errorlogs tell you where the error is, and an editor like PSpad shows you linenumbers and other helpful information. If you can't find a bug that way split your mod into sections, outcomment them one by one to see if disabling a certain section fixes the bug. Then split THAT section, and so on till you have found the line with the bug. And if all doesn't help rewrite your mod so that it works without the buggy section. And PLEASE stay around AFTER publishing, cause most bugs surface later.

I know that all this can be hard, boring labor, and I concede that I myself haven't done enough of it lately. But if we want to publish mods to PLAYERS we have to go through that. If you are not willing or able to do that (which I could quite understand, I often feel that way myself) then please be so fair to publish your work as "Experimental" for MODDERS only, with the explicit warning that you can not provide bugfixing service. It's not a shame to do so, on the contrary: it proves that you are a responsible person <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />

Note: This is meant to be a friendly appeal <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/bow.gif" style="vertical-align:middle" emoid=":bow" border="0" alt="bow.gif" /> It was not my intention to criticise anyone. If it sounds that way it is unintentional and only due to my limited English <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/smile.gif" style="vertical-align:middle" emoid=":)" border="0" alt="smile.gif" />
 
You're quite right, of course, CCC. But it seems like several of the people who did the coding aren't around for fixing. I personally haven't made much mods myself and the ones I did make are small and work reasonably properly (equip keys, mostly). Apart from the disarming mod, but I turned that one off. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/dunno.gif" style="vertical-align:middle" emoid=":shrug" border="0" alt="dunno.gif" />
If I can spare some time once, I will try to collect all reported bugs and put them onto my website. Then we can try to just fix them one by one, I hope... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
<!--QuoteBegin-alan_smithee+Oct 7 2005, 04:38 PM--><div class='quotetop'>QUOTE(alan_smithee @ Oct 7 2005, 04:38 PM)</div><div class='quotemain'><!--QuoteEBegin-->I'm trying to find that game someone mentioned on the forums a few months ago, I forget the name of it but it has the same file format as PotC so I wanted to try it.
<div align="right">[snapback]131985[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->
Voyage of the Century? <a href="http://forum.piratesahoy.net/index.php?showtopic=6135" target="_blank">Check out this topic</a>

I think that's what you're looking for, Alan!

And congrats on getting the internet at home! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/me.gif" style="vertical-align:middle" emoid=":onya" border="0" alt="me.gif" />
 
I don´t know who exactly made up it but the interior looks really great. I only miss here some working table with some flasks, alembic, retors, agate morhar, test tubes, dried herbs and so on. Could anybody add here anything like that? I think it could augment all the athmosphere yet a little.

And please, can anybody explain me what is "acetum saturninum",
what mean the words "enematic" and "turpeth"? I searched for those words in three dictionaries but vainly. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" />
 
<!--QuoteBegin-Rad+Oct 13 2005, 12:33 AM--><div class='quotetop'>QUOTE(Rad @ Oct 13 2005, 12:33 AM)</div><div class='quotemain'><!--QuoteEBegin-->I don´t know who exactly made up it but the interior looks really great. I only miss here some working table with some flasks, alembic, retors,  agate morhar, test tubes, dried herbs and so on. Could anybody add here anything like that? I think it could augment all the athmosphere yet a little. 
<div align="right">[snapback]132347[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->
Alan Smithee did that. He made the mod. He's also the guy to ask for the meaning of these words. I don't really know what they mean either. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
One think I know surely. Acetum saturninum is complete bullshit! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/w00t.gif" style="vertical-align:middle" emoid=":woot" border="0" alt="w00t.gif" />
 
ha ha. I just took the names of all those supposed medicinal substances from the Master & Commander series, I don't know if they're real or not. Maybe they were real centuries ago; they just sound obscure and archaeic-medicinal enough, plus I don't know of any real drugs that will increase your HP...

I wanted to add a lot more to the room but that's as far as I got with Ines' tool without overloading the room and crashing the program. I'm gonna get the newest version now, I haven't updated for a year, and see how that is. I also need to add some sort of shading to it, it's too bright inside.

Cat: That's the one, thanks. I got it all downloaded and hoo-boy...! I just can't make it play...
 
Hi, Alan. Believe me, you had to mishear somehow. I have some education from chemistry area and this acetum saturninum couldn´t exist neither in 17th century. I tried to invent anything real and wrote it here.
If I could please, could you replace this acetum saturninum with "root of Panax ginseng" ? This real herb is known for many centuries and it give people energy and vitality.

Instaead of laudenum, proper word is laudanum.

And instead of "powerful enematic" which is nonsense you could use the the words the "bottle of tincture from Uncaria tomentosa" or "dried liana Uncaria tomentosa". You could use what would be more comfortable for you, but more real would be this "dried liana Uncaria tomentosa". But it doesn´t matter. This is real herb - liana from rain forests of Peru and so on. It is very efficient natural preparation for increasing immunity and curing many diseases. It really can add people strength, health and stamina. And this doubtful "drachm of confectio Damocritis" I would replace for example by "a pound of honey form the rain forest bees". And this nonsense word turpeth I would replace with "several grains of Mumio". This old natural praparation has black colour and is used for enhancement organism, immunity and curing many diseases again. Laudanum could stay here because it was always used for softening various severe pains. If you would have some questions about it, please ask me. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" />
 
You must log in or register to reply here.
Back
Top