Low Priority Ship names depend on which nationality

[Pieter Boelen]

I just noticed that at some point in the past, I had basically made a function that already existed.
So today I merged it with the original and removed the second version. Bit cleaner code again!

The reason I ran into this is because I was quite surprised to buy a ship for an officer of mine that ended up named "Ter Goes".
That is quite a Dutch name. And while that officer IS Dutch, @Hotshot's player character was English.
So I would have expected an English name.

I did some slight code changes now to DO properly take into account the "player served nation" here.
But even that wasn't enough. Apparently if an officer has been in command of a ship before, that officer insists on reusing that name again.
This is especially funny if those officers are former enemy captains. That's some nice underhanded loyalty to their original nation!

Anyway, now that I know this is apparently on purpose, I think I'll leave it as-is.
Just thought I'd share this bit with you guys!

 

[Grey Roger]

If you're buying a ship, shouldn't its name be tied to the nationality of the shipyard where you're buying it? The new captain can rename it to whatever he likes, but when it's fresh out of the shipyard, wouldn't it have whatever name the shipyard gave it?

 

[Pieter Boelen]

If you're buying a ship, shouldn't its name be tied to the nationality of the shipyard where you're buying it? The new captain can rename it to whatever he likes, but when it's fresh out of the shipyard, wouldn't it have whatever name the shipyard gave it?

Strange thing is that the name is set before you even buy the ship.
Press the "Set Captain" button and you've got a name already.

 

[Pieter Boelen]

I don't think anything needs to be done here. I made a slight change and, while in theory it might be better still, it is quite pointless to do so by my reasoning.