Fixed Ship Interface String Problems

[Mere_Mortal]

Two things I just fixed on the ship interface...

The number displayed for ship turn did not have the decimal place. This was easily fixed by using the same format as the other attribute uses.

The string for the number of guns currently installed decides to not want to be displayed.

I fixed it by duplicating the CreateString, like so... [SNIP] Why that string was not being displayed, even if just “0”, is beyond me since it was correctly entered into the interface attributes. I don’t see why it should be necessary to do what I did here, but it sorts it out so I’m happy. Oh, now I get it. The skills summary is interfering with the cannons - as soon as the summary is displayed the cannons quantity changes to the skill value.

Yep, now I have changed the string name for the cannon quantity to QCannons and it has fixed the problem.

CreateString(true,"QCannons","0",FONT_BOLD_NUMBERS,COLOR_NORMAL,575,154,SCRIPT_ALIGN_CENTER,0.6);

GameInterface.strings.TCannons = GetCannonName(GetCaracterShipCannonsType(otherCh));
GameInterface.strings.QCannons = GetLocalShipAttrib(&tmpar,&refBaseShip,"CurCanQty");
if (sti(GameInterface.strings.QCannons) == 0 && GetCaracterShipCannonsType(refMyCh) == CANNON_TYPE_NONECANNON) {
   SetSelectable("RCANNONS", false);
   GameInterface.strings.QCannons = "";
}

 

[Pieter Boelen]

This is the F2>Ship Interface, right? And that one never displayed properly before?
Thanks for catching and fixing!

 

[Mere_Mortal]

Yeah, that one. Dunno if the turn rate was changed with the fix for unique ships, or what. As for the cannon string, that has been bugging me for some time because on occasion I might not notice a companion has lost a gun or three.

 

[Pieter Boelen]

Yeah, that one. Dunno if the turn rate was changed with the fix for unique ships, or what.

I don't remember the ship.c file being touched in a while.

 

[Mere_Mortal]

No, you’re right... the old 4.0 file is the same. Guess I just never noticed it before.

 

[Pieter Boelen]

@Mere_Mortal, when you're done with this, could you post the corrected file please?

 

[Mere_Mortal]

Should be good to go.

 

[Pieter Boelen]

So replacing "Cannons" with "QCannons" made it work? Wow.

But yes, I can confirm that it makes a difference. Thanks for catching and fixing it!

Edit: Extra suggestion of mine:

     GameInterface.strings.ShipSpeed  = FloatToString(stf(GetLocalShipAttrib(tempref, refBaseShip, "SpeedRate")),2);
     GameInterface.strings.ShipManeuver  = FloatToString(stf(GetLocalShipAttrib(tempref, refBaseShip, "TurnRate")),2); // MM

That brings it in line with the Shipyard Interface. Advantage is that "16" then displays as "16.0" instead of "16."

 

[Mere_Mortal]

Yep, it works because the Cannons string was also being used by the skills summary, so one of them had to change.

So basically, the fts function is pretty useless really and we should just use FloatToString instead?

 

[Pieter Boelen]

Yep, it works because the Cannons string was also being used by the skills summary, so one of them had to change.

Ah, that does explain it. Good catch indeed!

So basically, the fts function is pretty useless really and we should just use FloatToString instead?

I've never used fts myself; the game code usually converts stuff to string if necessary anyway.

Not sure about the differences between both functions.
All I know is that the Shipyard Interface apparently uses that FloatToString function for that purpose.

 

[Mere_Mortal]

I’ll certainly be keeping an eye on the string formatting, it seems quite touchy but I’m understanding it more.