Fixed Officers are erased when they shouldn't be

[Hylie Pistof]

I was on a treasure quest in Hispaniola where you have to fight your way through a cave. All went normally until I left the first cave to go on the cliff trail to the next one.

All my shore party disappeared! I didn't realize they were gone until I landed at the next island. Then I backtracked to where they took off. Oh, there was no treasure this time.


This has never happened to me before, and the only thing I have done differently is that I tried that "task manager and reset POTC.exe to realtime" thingy. It did nothing that I can tell.

 

[Levis]

I'm guessing the became a victim of @Pieter Boelen 's delete character function .

 

[Hylie Pistof]

Well, I saved my crew by going back to the last place they existed and removing them from my shore party, then continuing on alone.

 

[Pieter Boelen]

Waaaaa???? Does that always happen at the same point in the game?
Do you have a save from prior to that for me to test with?

Two things to try:

1. In PROGRAM\Locations\Locations_loader.c comment out this line:

LogoffCharactersFromLocation(loc);                   // PB: Permanently erase certain characters

That is a call to this function I added and that is intended to erase all unhired officers:

void LogoffCharactersFromLocation(ref loc)
{
   int i;
   ref chr;
   string locID = loc.id;
   for (i = 0; i < MAX_CHARACTERS; i++)
   {
     chr = &Characters[i];
     if (!CheckAttribute(chr, "location"))   continue;
     if (chr.location != locID)         continue;
     if (HasSubStr(chr.id, "Enc_Officer_") && !bAllies(chr)) DeleteCharacter(chr);
   }
}

2. In PROGRAM\Characters\characters.c find:

bool DeleteCharacter(ref character)
{
   // PB: Completely erase attributes -->
   int index  = character.index;
   string id  = character.id;
   string entity = character.model.entity;
   DeleteClass(character);
   DeleteAttribute(character, "");
   character.index = index;
   character.id = id;
   character.model.entity = entity;
   character.location = "none";
   character.location.locator = "";
   character.location.group = "";
   // PB: Completely erase attributes <--
   return true;
}

Replace with:

bool DeleteCharacter(ref character)
{
   DeleteClass(character);
   return true;
}

If indeed my code change for that is the cause, the first might solve it and the second definitely will.
Question does remain why that happens though.

 

[Hylie Pistof]

The included save is from before they disappear. I landed and went through the jungle to the cave and that save is just before the fight in there. Just lobe the stink bomb in there and be patient. When you leave that cave the officers will be gone.

 

[Pieter Boelen]

Fixed in the ZIP I just posted here: http://www.piratesahoy.net/threads/build-14-beta-3-5-internal-wip-for-testing.24817

Turns out in *some* cases DeleteCharacter was used to just temporarily not have certain characters in a location.
But other times it was used to completely clear an unused character so that slot can be used for a new one.
Having it ALWAYS erase the character therefore had some unintended side-effects.

I have now applied a much safer solution: My rewritten function is now called ClearCharacter and DeleteCharacter has gone back to its original state.
ClearCharacter is now only called in instances where I reckon that is actually a good idea.
So your officers do stay with you now.

 

[Grey Roger]

During the "Help the Lady" side quest, I talked to Armand Delacroix, and when I'd finished, this was what my "Passengers" screen looked like:


Also, my then current companion officers were replaced by blank entries in the "Characters" screen. Enclosed are log files and a savegame.

A similar problem occurred during the "Silver Train" side quest when I talked to the prisoner in the mine. So I've enclosed a savegame from there, too. The savegames are from just before you do the talking which results in the error.

 

[Pieter Boelen]

Also fixed this weekend: http://www.piratesahoy.net/threads/lost-crew.25389/

 

[Pieter Boelen]

Merged duplicate issues.

 

[lucho1392]

Well started Master & Commander and at the beggining you have officers with you but in time my gunner has 1 in all skills and abilities that i selected are no longer avaible, i have the "share experience" thing so there are times in "X" situation that "xxxxxxx has gained a level" pops up and i guess it means my "ghost officer" that was lvl 10 has gained a lvl (from 1 to 2) but it never does they always stay in lvl 1.

 

[Pieter Boelen]

Do you have the zip from the link in my signature?
If not, get it IMMEDIATELY!

 

[Levis]

@lucho1392 can you confirm this is done in the newest version of the game?

Or can anyone else replicate this problem?

 

[lucho1392]

Do you have the zip from the link in my signature?
If not, get it IMMEDIATELY!

With Zip you mean "Part 2"? If so I do have it.

@lucho1392 can you confirm this is done in the newest version of the game?

Uploading screenshot so u can see the game version.

 

[Hylie Pistof]

No, Pieter means the first item in the "download" line. The one that was updated a week or so ago.

 

[lucho1392]

No, Pieter means the first item in the "download" line. The one that was updated a week or so ago.

Aye i have it. And have found more issues but will post them later

P.D: Save game uploaded (is a free play save game but has the same problem)

 

[Pieter Boelen]

2 Jul is definitely out of date already.
You need also the zip file attached in the post linked in my signature.

 

[lucho1392]

Ok missed the zip cuz it is at the post end hahaha
So do i have to put the zip file inside a carpet with the archives and .exe?

 

[Pieter Boelen]

Extract the contents to your main game folder as last step in the process.
I'm pretty sure that is already explained in the first post linked to in my signature.

 

[lucho1392]

Ok file extracted but theres no way i can get the officer i want from the tavern keeper.

 

[Pieter Boelen]

That works once a day. Wait the night and see if that helps.