Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!
Join our discord server for regular podcasts/AMA about upcoming and released pirate games (Caribbean Legend, Corsairs Legacy, Ahoy, ERAS 2, etc.):
Quick links for Beyond New Horizons
- Download latest version
- Wiki
- FAQ
- Report bugs here
- Bug Tracker on Github
Quick links for Maelstrom
- Download the latest version of Maelstrom
- Download the latest version of ERAS II
- Download the latest version of New Horizons on Maelstrom
Join PiratesAhoy! on our social channels:
Quick links for PotC: New Horizons
- Download latest version
- Wiki
- FAQ
- Report bugs here
Thanks to YOUR votes, GOG.com now sells:
- Sea Dogs
- Sea Dogs: Caribbean Tales
- Sea Dogs: City of Abandoned Ships
Vote now to add Pirates of the Caribbean to the list!
Quick links for AoP2: Gentlemen of Fortune 2
- Downloads and info
- ModDB Profile
- Forums Archive
A Pirate Podcast with Interviews
Music, Comedy and all things Pirate!
- Episode Guide - About - Subscribe -
- Twitter - Facebook - iTunes - Android -
- Youtube - Fill the Coffers -
OOOooohhhh.....
We all have our thresholds and commitments.
No worries; there will certainly be another update soon. Once there is something to include, that is.
No worries; there will certainly be another update soon. Once there is something to include, that is.
string OfficerUniform4Player(int PlayerRank, int iNation)
{
ref pchar = GetMainCharacter();
if (!CheckAttribute(pchar, "model")) return "";
if (ProfessionalNavyNation() == UNKNOWN_NATION) return "";
if (pchar.sex == "woman") return "";
if (GetAttribute(PChar, "location") == "Tutorial_Deck") return ""; // PB: Skip this on Start New Game
string PlayerModel = "";
switch(iNation)
{
case ENGLAND:
switch(PlayerRank)
{
case 1: // Midshipman
switch(GetMySimpleName(PChar))
{
case "James Norrinton":
PlayerModel = "Mdnorrington";
break;
// default
if (HasSubStr(pchar.model, "blaze"))
{
PlayerModel = "47_Blaze_brtmds";
}
else
{
switch(rand(3))
{
case 0: PlayerModel = "brtmds1_18"; break;
case 1: PlayerModel = "brtmds2_18"; break;
case 2: PlayerModel = "brtmds3_18"; break;
case 3: PlayerModel = "brtmds4_18"; break;
}
}
}
break;
case 2: // Junior Lieutenant
switch(GetMySimpleName(PChar))
{
case "Jack Sparrow":
PlayerModel = "47_Ltsparrow";
break;
case "James Norrington":
PlayerModel = "Ltnorrington";
break;
case "Andrew Gillette":
PlayerModel = "Gillette";
break;
case "Horatio Hornblower":
PlayerModel = "brtH3rdLt_18";
break;
// default
if (HasSubStr(pchar.model, "blaze"))
{
PlayerModel = "47_Blaze_brtlt";
}
else
{
if (HasSubStr(pchar.model, "JRMM"))
{
PlayerModel = "47_JRMMLt1";
}
else
{
switch(rand(2))
{
case 0: PlayerModel = "brtlut1_18"; break;
case 1: PlayerModel = "brtlut2_18"; break;
case 2: PlayerModel = "brtlut3_18"; break;
}
}
}
}
break;
case 3: // Lieutenant
break;
case 4: // Senior Lieutenant
case 5: // Commander
switch(GetMySimpleName(PChar))
{
case "Horatio Nelson":
PlayerModel = "Cpnnelson";
break;
case "Jack Aubrey":
PlayerModel = "Aubrey";
break;
}
break;
case 6: // Post Captain
switch(GetMySimpleName(PChar))
{
case "Jack Sparrow":
PlayerModel = "47_Cptsparrow";
break;
case "James Norrington":
PlayerModel = "Cpnorrington";
break;
case "Horatio Hornblower":
PlayerModel = "brtHComdr_18";
break;
case "Jack Aubrey":
// Intentionally nothing (skip generic model)
break;
// default
if (HasSubStr(pchar.model, "blaze"))
{
PlayerModel = "47_Blaze_brtcpt";
}
else
{
if (HasSubStr(pchar.model, "JRMM"))
{
PlayerModel = "47_JRMMCpt";
}
else
{
switch(rand(1))
{
case 0: PlayerModel = "brtcpt1_18"; break;
case 1: PlayerModel = "brtcpt2_18"; break;
}
}
}
}
if (pchar.model == "Groves")
{
PlayerModel = "GrovesCpt";
}
if (pchar.model == "Gillette")
{
PlayerModel = "GilletteCpt";
}
if (pchar.model == "Groves_EITC")
{
PlayerModel = "GrovesCpt_EITC";
}
break;
case 7: // Commodore
switch(GetMySimpleName(PChar))
{
case "Jack Sparrow":
PlayerModel = "47_Cosparrow";
break;
case "James Norrington":
PlayerModel = "Conorrington";
break;
case "Horatio Hornblower":
PlayerModel = "brtHComdr_18";
break;
case "Jack Aubrey":
// Intentionally nothing (skip generic model)
break;
// default
if (HasSubStr(pchar.model, "blaze"))
{
PlayerModel = "47_Blaze_brtco";
}
else
{
PlayerModel = "brtbath_18";
}
}
if (pchar.model == "GrovesCpt")
{
PlayerModel = "GrovesC";
}
if (pchar.model == "GilletteCpt")
{
PlayerModel = "GilletteC";
}
break;
case 8: // Rear Admiral
break;
case 9: // Vice Admiral
break;
case 10: // Admiral
switch(GetMySimpleName(PChar))
{
case "Jack Sparrow":
PlayerModel = "47_Admsparrow";
break;
// default
if (HasSubStr(pchar.model, "blaze"))
{
PlayerModel = "47_Blaze_brtadm";
}
else
{
switch(rand(1))
{
case 0: PlayerModel = "brtadm1_18"; break;
case 1: PlayerModel = "brtadm2_18"; break;
}
}
}
if (pchar.model == "GrovesC")
{
PlayerModel = "GrovesA";
}
if (pchar.model == "GilletteC")
{
PlayerModel = "GilletteA";
}
if (pchar.model == "Conorrington")
{
PlayerModel = "ANorrington";
}
break;
}
break;if you upload your file I might be able to look at it tomorrow. But I think you will figure it out. Or else post the error it gives and note which line is pointed at.
Was a stupid case of earlier on i forgot to close off a case with a break.....OH MY GOD! 
You can use Winmerge to easily merge them together.
But maybe it easier if you just upload them. Then we can do the winmerge and while doing that directly check if something is weird
case "James Norrington":
ch = CreateOfficer_Cheat(OFFIC_TYPE_FIRSTMATE, "Groves", 3, iNation, false);
ch.name = TranslateString("","Theodore");
ch.lastname = TranslateString("","Groves");
GiveItem2Character(ch, "blade24+3");
GiveItem2Character(ch, "PiratesPistol+2");
ch.equip.blade = "blade24+3";
ch.equip.gun = "PiratesPistol+2";
ch.HPBonus = 100;
ch.professionalnavy = ch.nation;
SetRank(ch, iNation, 4);
SetRankTitle(ch, ENGLAND, TranslateString("", "Lieutenant Commander"));
break;
There is. At each rank, you'll see a block starting with 'switch(GetMySimpleName(PChar))'. A 'switch' statement looks at what's in the brackets - here it's the player character's basic name, e.g. "James Norrington" without any rank or title - and then jumps to whichever of the 'case' statements matches it. (The entry at Midshipman rank isn't going to work because someone has written "Norrinton" instead of "Norrington". But that's not the cause of your syntax error because, looking back at an older version of "Nk.c", the error is in there as well.) So you could possibly do something similar for the uniforms, e.g.:
switch(pchar.model)
{
case "Groves": PlayerModel = "GrovesA";
case "GilletteC": PlayerModel = "GilletteA";
case "Conorrington": PlayerModel = "ANorrington";
}if (pchar.model == "Groves") PlayerModel = "GrovesCpt";I've done that quite a few times as well.EDIT: 5 Minutes later - Got the B******!
Likewise.I've done that quite a few times as well.
) )
You mean in case you are playing as Mr. Groves? Because of course there are no promotions for companion officers at the moment.
Hmm, I can't find now where that is controlled. Maybe those instances are hard-coded in the dialog.h files, which makes it impractical to change.
//get chr's formal name: Nathaniel Hawk or Christofor Manuel De Alencar
//normally same as "GetMySimpleName", but fills in blank firstnames with Captain/Mister
string GetMyFormalName(ref chr)
{
string name = "";
if(!CheckAttribute(chr,"name")) chr.name = name;//MAXIMUS -->
if(!CheckAttribute(chr,"lastname")) chr.lastname = name;
if (CheckAttribute(chr,"title")) {
if (XI_ConvertString(chr.title) != "") chr.title = XI_ConvertString(chr.title);
name = chr.title + " ";
}
else
{
// PB: Use appropriate title if no first name available -->
if (chr.name == "")
{
if(CheckAttribute(chr,"Ship.type") && chr.Ship.type!="" && chr.Ship.type!=SHIP_NOTUSED_TYPE_NAME)
{
name = XI_ConvertString("captain") + " "; // Use "Captain" if in command of a ship, but without rank
}
else
{
name = GetCharacterAddressForm(chr, ADDR_CIVIL, false, false) + " "; // Otherwise return a civil address form without name
}
}
// PB: Use appropriate title if no first name available <--
}
name += GetMySimpleName(chr); // KK
return name;
}SetRankTitle(ref char, string newtitle)
Hmm, I can't find now where that is controlled. Maybe those instances are hard-coded in the dialog.h files, which makes it impractical to change.
The only thing I DID find is this from PROGRAM\Dialog_func.c:
But that only affects characters without a first name.Code://get chr's formal name: Nathaniel Hawk or Christofor Manuel De Alencar //normally same as "GetMySimpleName", but fills in blank firstnames with Captain/Mister string GetMyFormalName(ref chr) { string name = ""; if(!CheckAttribute(chr,"name")) chr.name = name;//MAXIMUS --> if(!CheckAttribute(chr,"lastname")) chr.lastname = name; if (CheckAttribute(chr,"title")) { if (XI_ConvertString(chr.title) != "") chr.title = XI_ConvertString(chr.title); name = chr.title + " "; } else { // PB: Use appropriate title if no first name available --> if (chr.name == "") { if(CheckAttribute(chr,"Ship.type") && chr.Ship.type!="" && chr.Ship.type!=SHIP_NOTUSED_TYPE_NAME) { name = XI_ConvertString("captain") + " "; // Use "Captain" if in command of a ship, but without rank } else { name = GetCharacterAddressForm(chr, ADDR_CIVIL, false, false) + " "; // Otherwise return a civil address form without name } } // PB: Use appropriate title if no first name available <-- } name += GetMySimpleName(chr); // KK return name; }
Probably the option suggested in my previous post with using SetRankTitle and DeleteAttribute will be the simplest way to get close to what you want.
As additional note, I have just changed the syntax to:
There is no need for nation to factor in there and, in fact, it didn't anyway; it just pretended to.Code:SetRankTitle(ref char, string newtitle)
You add SetRankTitle(ch, TranslateString("", "Commander")); at the promotion to Junior Lieutenant.
