Fixed Levelling: Cannonball Hits Slow Down Game

[Mirsaneli]

Let me know if its still there indeed

Yep, it still occurs.

 

[Levis]

Ok....might look into it later..

 

[Pieter Boelen]

Yep, it still occurs.

The slow-down when destroying ships' cannons? Or the lag when cannonballs hit?

For the "destroying cannons", I found this in PROGRAM\SEA_AI\AIShip.c:

        if(IsMainCharacter(rOurCharacter)) { // KK
           PlaySound("interface\notebook.wav"); // like CCC's firedrill
           logit(TranslateString("","We lost a cannon! From the") + " " + TranslateString("",GetQuadText(quad)) + " " + XI_ConvertString("arc") + "!" + stringret(fix," " + TranslateString("","We think we can fix it, captain."), ""));
         }
         else
         {
           if(iKillerCharacterIndex == GetMainCharacterIndex())
           {
             logit(TranslateString("","We knocked out one of") + " " + GetMyShipNameShow(rOurCharacter) + TranslateString("","'s") + " " + XI_ConvertString(GetQuadText(quad)) + " " + TranslateString("","guns!")); // KK
             PlaySound("objects\shipcharge\hurrah.wav");
           }
         }
         Play3DSound("cannon_explosion", x, y, z); // KK
         if(AUTO_SKILL_SYSTEM)
         {
         // LDH divide experience between cannons and accuracy - 27Dec08
           Ship_AddDelayedCumXP(GetCharacter(iKillerCharacterIndex), "Cannons", 750);
           Ship_AddDelayedCumXP(GetCharacter(iKillerCharacterIndex), "Accuracy", 750);
           Ship_AddDelayedCumXP(rOurCharacter, "Defence", 500);
           Ship_AddDelayedCumXP(rOurCharacter, "Cannons", 250);
           Ship_AddDelayedCumXP(rOurCharacter, "Accuracy", 250);
         }
         Ship_Serious_Boom(x, y, z);

You could comment out those 'Ship_AddDelayedCumXP' lines there and see if that makes a difference for you.

 

[Levis]

I think its the
Ship_Serious_Boom
function which causes the lag in this case....

 

[Pieter Boelen]

In that case, @Mirsaneli, how about you comment that out and see what happens?

It does very little though:

void Ship_Serious_Boom(float x, float y, float z)
{
   CreateBlast(x,y,z);
   CreateParticleSystem("blast_inv", x, y, z, 0.0, 0.0, 0.0, 0);
   Play3DSound("ship_explosion", x, y, z);
}

 

[Mirsaneli]

No, it happens only when you destroy enemies cannon. Since firing with a large number of cannons raises chance to destroy enemies guns, it is more visible when sailing largers ships.

I will gladly test that.

 

[Pieter Boelen]

Started a new game on Standard and gave myself the Soleil Royal, then went to harass the Speighstown blockading squadron.
All seemed smooth enough.

Did get this in compile.log though:

XP ERROR: No officertype assigned to: Remy Gatien now set to: fighter
For character 993 fall Mast name mast4 has index 4
XP ERROR: No officertype assigned to: Begon Monchaty now set to: fighter
XP ERROR: No officertype assigned to: Yves Giner now set to: fighter

And I also got this: Confirmed Bug - Sea Battles: Crash for virtual function call | PiratesAhoy!