Having given this some further thought - I think the change in Jack Sparrow's relations with the various nations should be consistent between the 2 stories ( Mings-Brotherhood and Brock Brinkley) otherwise there is going to be a lot of work changing relations in the Brock-Brinkley Story especially with all the different paths it has.
Since both main stories have 4 points in common I think that any changes to Jack Sparrow's Served Nation should occur at the first 3 of those points.
the 4 common points are:-
1- The Start
2- Meeting Tia Dalma at Muscetto Cove
3- Beckett Burning Wicked Wench / meeting Davy Jones
4- Curse of the Black Pearl ( film quest)
At the Start I think Jack should have Served Nation as English since that is what he is and although he is working for Mings in the Brotherhood he is not yet committed to them, in the Brock-Brinkley story he is looking for the Governor's daughters and working for/with Shaypen.
When Jack meets Tia Dalma - he decides to desert Beckett so he is no longer English - but has not yet fully committed to the Pirates so I think his Served Nation should be Personal.
When Beckett captures Jack and destroys the Wicked Wench and Jack meets Davy Jones, from then he is fully committed to the Pirates and his Served Nation is Pirate.
This would give a constent structure for Jack Sparrow's relations with the Nations for the 2 Main Stories
If we don't keep the changes consistent between the 2 Main Stories, then in the Brock - Brinkley story story it is going to be confusing, for instance, since Beckett can hire you both in Port Royale and Speightstown depending on which path the player chooses, and a lot of work is going to have to be done to change the relations during that story.
- France becomes hostile when attacking the 'Volcano' (When does this happen? Isn't that the Hornblower storyline???)
This is in Brock-Brinkley - when you are trying to talk to Barbossa on Martinique - sink the Volcano so you become Barbossa's friend.
- England technically turn hostile in THIS quests_reaction.c case, which is just prior to the deal with Davy Jones:
Code:
case "sunk_wench":
GiveShip2Character(pchar,"HMS_Bounty","Lindesfarne",ENGLAND,-1,true,true);
HoistFlag(PERSONAL_NATION);
PChar.Flags.Personal = 3; // PB: EITC Flag
PChar.Flags.Personal.texture = 3;
break;
Actually, perhaps the whole "joining the pirates" thing should occur ONLY if you accept the deal.
But if you decline, England should still turn hostile, no? You still double-crossed Beckett, after all.
Agreed - if you don't accept the deal you are taken out of the story - which I think people only play by accident.
From my side, I reckon the best way to deal with this though is to:
1. Set England hostile when the Wench is burned
2. Set the Pirates friendly when you accept the deal with Davy Jones
3. Change the dialog with Davy Jones to indicate that you now CAN join the Pirate Brotherhood at Nevis IF YOU WISH!
That allows deliberate player choice there, but WILL still turn ALL nations hostile if you choose to do so.
So what would your Served Nation be if you don't go and see the Pirates on Nevis -- still Personal ?
(Perhaps Personal Nation start should have all nations Wary, rather than Neutral?)
That sounds a good suggestion for a general principle