Fixed Incorrect Officer Types Assigned for Player and Quest Characters

[Pieter Boelen]

Bush is the officer who shows up as "Captain" when you're a captain and he's your lieutenant.

Ah, yes; but I think we can safely consider that a different and unrelated issue:
Confirmed Bug - Captain Remains Captain After Being Removed From Command | PiratesAhoy!

 

[Levis]

@Levis: For the Beta 4 public release, we may want to slightly reconsider this code:

  if (!CheckAttribute(GameInterface.strings,"OfficerType"))
   {
     // SUBTITLE: Officer type
     GameInterface.strings.OfficerType = XI_ConvertString(GetAttribute(xi_refCharacter, "quest.officertype"));

     // TITLE: Indicate character type/category
     if (IsMainCharacter(xi_refCharacter))
     {
       GameInterface.strings.fakeTitle  = XI_ConvertString(GetAttribute(xi_refCharacter, "quest.officertype"));
       GameInterface.strings.OfficerType = XI_ConvertString(GetCaptainType(xi_refCharacter)); // PB: Indicate Player Type as subtitle to ensure it ALWAYS displays
     }

Most notably, there is probably very little point in showing the player officer type that is stored at the beginning of the game, then never updated.

So let's make it getcaptaintype?

 

[Pieter Boelen]

So let's make it getcaptaintype?

GameInterface.strings.OfficerType already is.
But for testing purposes, fakeTitle isn't. That one will be overwritten anyway if you get any sort of rank.
There just needs to be a default text of some kind there.

Having the same thing displayed twice seems a bit superfluous to me.
Maybe just make it say "Player" for the fakeTitle? Or display the CharPlayerType selected at game start?

 

[Levis]

GameInterface.strings.OfficerType already is.
But for testing purposes, fakeTitle isn't. That one will be overwritten anyway if you get any sort of rank.
There just needs to be a default text of some kind there.

Having the same thing displayed twice seems a bit superfluous to me.
Maybe just make it say "Player" for the fakeTitle? Or display the CharPlayerType selected at game start?

When you have a rank somewhere it will show that right?

 

[Pieter Boelen]

When you have a rank somewhere it will show that right?

Yes. So the question is what to show when you don't have a rank.

 

[Levis]

Yes. So the question is what to show when you don't have a rank.

I think the starttype would be nice indeed.

 

[Pieter Boelen]

I think the starttype would be nice indeed.

So that could be any of the below:

#define PLAYERTYPE_ADVENTURER  "Adventurer"
#define PLAYERTYPE_AGENT  "Agent"
#define PLAYERTYPE_MILITARY  "Army Veteran"
#define PLAYERTYPE_CORSAIR  "Corsair"
#define PLAYERTYPE_ENGINEER  "Engineer"
#define PLAYERTYPE_EXPLORER  "Explorer"
#define PLAYERTYPE_GAMBLER  "Gambler"
#define PLAYERTYPE_GUNNER  "Gunner"
#define PLAYERTYPE_MARINE  "Marine"
#define PLAYERTYPE_MERCHANT  "Merchant"
#define PLAYERTYPE_NAVALOFFICER  "Naval Officer"
#define PLAYERTYPE_PHYSICIAN  "Physician"
#define PLAYERTYPE_QUARTERMASTER  "Quartermaster"
#define PLAYERTYPE_REBEL  "Rebel"
#define PLAYERTYPE_ROGUE  "Rogue"
#define PLAYERTYPE_SAILOR  "Sailor"
#define PLAYERTYPE_SHIPWRIGHT  "Shipwright"
#define PLAYERTYPE_SMUGGLER  "Smuggler"
#define PLAYERTYPE_SOCIALCLIMBER  "Social Climber"
#define PLAYERTYPE_SWORDMASTER  "Sword Master"
#define PLAYERTYPE_CURSED    "Cursed"
#define PLAYERTYPE_CUSTOM  "Custom"
#define PLAYERTYPE_LAND_OWNER  "Land Owner"

 

[Levis]

Yup, that sounds good right?
Although custom should maybe give something else.

 

[Pieter Boelen]

Although custom should maybe give something else.

Can only be selected with Auto Skill System OFF anyway.

 

[Pieter Boelen]

Done:

    // TITLE: Indicate character type/category
     if (IsMainCharacter(xi_refCharacter))
     {
       GameInterface.strings.fakeTitle    = XI_ConvertString(GetPlayerType (xi_refCharacter));   // PB: Player Type can be overridden by titles
       GameInterface.strings.OfficerType   = XI_ConvertString(GetCaptainType(xi_refCharacter));   // PB: Indicate Captain Type as subtitle to ensure it ALWAYS displays
     }

So now the player quest officer type will NEVER be shown ANYWHERE.

@Levis: Can you confirm for certain that also doesn't actually serve any purpose?
Because if it does, then we're hiding something that actually should be changed at certain spots in the game, but currently isn't.

 

[Levis]

Done:

    // TITLE: Indicate character type/category
     if (IsMainCharacter(xi_refCharacter))
     {
       GameInterface.strings.fakeTitle    = XI_ConvertString(GetPlayerType (xi_refCharacter));   // PB: Player Type can be overridden by titles
       GameInterface.strings.OfficerType   = XI_ConvertString(GetCaptainType(xi_refCharacter));   // PB: Indicate Captain Type as subtitle to ensure it ALWAYS displays
     }

So now the player quest officer type will NEVER be shown ANYWHERE.

@Levis: Can you confirm for certain that also doesn't actually serve any purpose?
Because if it does, then we're hiding something that actually should be changed at certain spots in the game, but currently isn't.

Confirmed