• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Gunsmith functionality

Pieter Boelen

Pieter Boelen

Navigation Officer
Administrator
Storm Modder
Hearts of Oak Donator
I'm trying to enable blacksmiths to also repair guns. What I already made is a blacksmith_dialog.c and .h file changed into gunsmith_dialog.c and .h files. That seems to be working, when I assigned that dialog to Gregor Samsa. Now I would like to know how to merge that functionality in with the blade repairing dialog, so we'd have a smith capable of repairing both blades and guns.

Also: There are additional blacksmith-concerning functions in the blacksmith#_dialog.c files that migth do well to be moved over into a more general file, because there are now six dialog files using this. Into what file might I move this so that this will still work? And how should that be done? Preferrably, I would like to be able to even have those functions work in SEADOGS.c, because I could use them for improving my Quick-Equip button (by having the game tell you the actual name of the stuff you equiped, instead of telling only that you equiped something).

Anyone wanting to have the dialogfiles, just ask. As it is now, it's basically just the exact blacksmith_dialog.c/h files with everything that says blade/sword replaced with gun. Hopefully, I'll come round to doing a better version later, with better dialog, but especially with better, merged, functionality.
BTW: Anyone think it'd be nice to have at least one gun-only smith somewhere in the archipelago? Alan Smithee had been trying to put some variation into the blacksmiths, so this might play into that nicely.

Hope you can give me a hand with these things. Thanks in advance! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/bounce.gif" style="vertical-align:middle" emoid=":b:" border="0" alt="bounce.gif" />
 
If you take it out of the dialog file it'll work anywhere.
I suggest putting them in items_utilite.c, that's where Scheffnow put most of his weaponsmod handling functions.

You also need to change
string GetBladeUpgradePrice(string BladeID, int CurrentQuality, int RequiredQuality)
and its gun version to
string GetBladeUpgradePrice(string BladeID, int CurrentQuality, int RequiredQuality, float pricemult)

and change line
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->UpgradePrice += (IntermediatePrice / XXX) * BLACKSMITH_PROFITPERCENT;<!--c2--></div><!--ec2-->
to
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->UpgradePrice += (IntermediatePrice * pricemult) * BLACKSMITH_PROFITPERCENT;<!--c2--></div><!--ec2-->
And then when calling the function in each blacksmith dialog, add the pricemult there.

This is because in the existing dialogs, there's that XX (anywhere from /70 to /130 or so, IIRC) that changes the price calc for each smith.

Anyway. To merge the two, in node selectfix, there's the line
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->if (BladeID != "" && makeint(GetBladeUpgradePrice(BladeID, BladeQuality, QUALITY_EXELLENT)) > 0 )<!--c2--></div><!--ec2-->
That starts a truly humongous if() { } block.
You need to make a second copy that checks for a gun, and change all the link.lX to be, say, 11 through 14 instead of 1 through 4 (Otherwise the gun links will overwrite the blade links).
Then also rename the various nodes further, i.e. for MakeExcellent make two copies, BladeMakeExcellent and GunMakeExcellent.

Oh, and make duplicates of any variable with Blade in it (and call the dupe Gun...)
 
Thanks for the help. I'll be trying that out soon. Hope I'll be having some luck... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />

<span style='color:red'>Edit:</span> Oh. And where is the pricemult defined? <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
It's an edit to the function header in each case:
string GetBladeUpgradePrice(string BladeID, int CurrentQuality, int RequiredQuality, float pricemult)
(it's added at the end)
Then, when you call GetBladeUpgradePrice() in something, also add the pricemult as the last argument.

(And ditto for the gun version)

G'luck! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/smile.gif" style="vertical-align:middle" emoid=":)" border="0" alt="smile.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" />
 
<!--QuoteBegin-NathanKell+May 9 2005, 05:43 AM--><div class='quotetop'>QUOTE(NathanKell @ May 9 2005, 05:43 AM)</div><div class='quotemain'><!--QuoteEBegin-->and change line
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->UpgradePrice += (IntermediatePrice / XXX) * BLACKSMITH_PROFITPERCENT;<!--c2--></div><!--ec2-->
to
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->UpgradePrice += (IntermediatePrice * pricemult) * BLACKSMITH_PROFITPERCENT;<!--c2--></div><!--ec2-->
And then when calling the function in each blacksmith dialog, add the pricemult there.

This is because in the existing dialogs, there's that XX (anywhere from /70 to /130 or so, IIRC) that changes the price calc for each smith.

<div align="right">[snapback]104538[/snapback]</div><!--QuoteEnd--></div><!--QuoteEEnd-->

Hmmm, I thought different pricing (fair, bargain, gouging) between blacksmiths is what Alan planned.
 
Exactly.
This is a way to both allow individual pricing and not require a separate copy of GetBladeUpgradePrice() for each blacksmith.
Now instead of calling GetBladeUpgradePrice(bladeid, etc) in the dialog with the price multiplier /hardcoded/ in the function, you call GetBladeUpgradePrice(bladeid, etc, 1.2) or whatever, and whatever pricemult you pass (in this case 1.2) will be used.
 
I just found out that I made this change to the code once:<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->// Wait a day
WaitDate("", 0, 0, 1, 0, 0);
if (BLACKSMITH_PAY_OUT_WEALTH == 1) // PB: Toggle blacksmith payment in BS.h
{Log_SetStringToLog("You get your blade back one day later. ");}
else
{Log_SetStringToLog("You get your blade back one day later. ");}<!--c2--></div><!--ec2-->What the HECK??? What good is that? That's completely superfluous!!! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/piratesing.gif" style="vertical-align:middle" emoid=":shock" border="0" alt="piratesing.gif" />
I must've been out of my mind! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />
 
Well, I've been working on getting the default blacksmith code to also support the repairing of guns and <a href="http://millenniumdock.bravepages.com/storage/others/gunsmith_mod.zip" target="_blank">here</a> is what I already have made. It contains the proper new Items_Utile.c file and one blacksmith_dialog.c file. Unfortunately, the second file won't work for some reason that I do not understand. Apparently, there is something wrong with the line "if (GunID != "" && makeint(GetGunUpgradePrice(GunID, GunQuality, QUALITY_EXELLENT, pricemult)) > 0 )". I thought maybe it had to do with duplicate variables or attributes or whatever, so I changed QUALITY_EXELLENT into QUALITY_GUN_EXELLENT and QUALITY_BLADE_EXELLENT. Only that caused a bug in the new line "if (BladeID != "" && makeint(GetBladeUpgradePrice(BladeID, BladeQuality, QUALITY_BLADE_EXELLENT, pricemult)) > 0 )", which HAD been working before, with just QUALITY_EXELLENT.
PLEASE HELP!!! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />

Also: You'll find that I added the "GetBladeUpgradePrice(BladeID, BladeQuality, QUALITY_BLADE_EXELLENT, pricemult)" change, but I also added "float pricemult = 1;", so that you'll only need to change the price multiplier once for every blacksmith.
 
You needed to define GunID and GunBaseID as well as the blade versions, up at the top.
Also, the qualities should have been without adding blade or gun (my mistake, I said to change everything. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/blush.gif" style="vertical-align:middle" emoid=":eek:ops" border="0" alt="blush.gif" />)
Other than that, seemed to work fine, though I haven't done much other than say hi. So <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" /> to you!

I also took the liberty of making the GetBlade/GunXYZ() functions general, to avoid duplication.

In the fleets archive I just upped is the non-crashy dialog (and items_utilite), and edited blacksmith dialogs as well.
 
To anyone wanting to test a (semi)working gunsmith, please download <a href="http://millenniumdock.bravepages.com/storage/others/gunsmith_mod.zip" target="_blank">this file</a> and extract it on top of your PotC installation. It will certainly work with PotCMods.zip, but it might even work for the default Build 12. This will change the Douwesen smith from just a bladesmith into a blade- and gunsmith. I've quickly tested it and it seems to be working more-or-less, but not quite perfectly yet. I hope you can help me a bit. Only I shouldn't have time to change anything the coming 1,5 weeks, because I'll be having exams.
( <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/diomed.gif" style="vertical-align:middle" emoid=":dio" border="0" alt="diomed.gif" /> AAAARRRRRRGGGGGHHHHH!!!!!! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/piratesing.gif" style="vertical-align:middle" emoid=":shock" border="0" alt="piratesing.gif" /> )
 
That's great (about the mod) Pieter! I've downloaded it and will give it a try if I get a chance, later today. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />

And good luck on your exams! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/bookish.gif" style="vertical-align:middle" emoid=":mm" border="0" alt="bookish.gif" />
 
Hope you do well, I know the feeling. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/bookish.gif" style="vertical-align:middle" emoid=":mm" border="0" alt="bookish.gif" />

Anyway, that mod sounds incredibly useful. Ill try to test it if I have time.
 
<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" />
I'll be sailing over to Douwesen later today so I'll be able to give this a try.
 
If it works, we need to put this into a patch right away! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" />
 
Installed it and started a new game using Modhelper to start directly at Douwesen.

The gunsmith acted properly swords but refused to recognize an enabled pistol.
 
"Equip a gun, a proper gun, before you talk to me", I'd imagine. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/sad.gif" style="vertical-align:middle" emoid=":(" border="0" alt="sad.gif" />
I did get him to repair one gun of mine; for some reason, when I talked to him again, he thought I didn't have a gun equiped. And I don't understand what's causing the trouble either. Someone capable of helping: PLEASE DO!!! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />
I know the coding part should be working properly for the major part; apparently still not totally working properl yet though. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" />
 
Hmm. Check what differences there are between the swordsmith and gunsmith codes, and that might give us a clue to whats going on.
 
I just briefly read the above and haven't tried the gunsmith thingy yet but what you describe sounds familiar... when I get that from a swordsmith, I just re-equip the same blade I wanted fixed and it works.
 
Are we happy with the blacksmiths? Should some be added/moved to the new islands?
What about a blacksmith interface for batch upgrades? Needed/not needed?
 
You must log in or register to reply here.
Back
Top