• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Fixed GetPatrolTimeText Can Cause Crashes

Pieter Boelen said:
AoP is a different game altogether.
Click to expand...
Oh dont get confused. My carpet is called like that but it is the MoD game.

Pieter Boelen said:
I see attachments now, but why is there no "compile.log"? There must be one!
Click to expand...
Sorry, uploading the compile log.

EDIT: Trying the smugling fix you linked may have fixed one crash. But got to try if there is random crashing ocurring.
 

Attachments

  • compile.log
    2.9 KB · Views: 183
Last edited:
Might I assume you get these crashes when you are walking around ashore and/or if dialogs are being started with characters?
Especially in taverns? Or perhaps when talking to one of your officers in certain locations?

lucho1392 said:
Sorry, uploading the compile log.
Click to expand...
Thanks. Indeed you do have the very latest version I posted.

However, the "latest version" is a bit out-of-date by now. Making a new one is high on my priority list, but may have to wait until Sunday or so.
In the meantime, install the fix from here: Fixed - GetPatrolTimeText Can Cause Crashes | PiratesAhoy!

According to your error.log file, that is indeed the problem that you ran into.
 
Yeah hahaha wrote that the smugling crash was fixed but still need to see if theres any random crashes ocurring. Because before that smugling problem the game just crashed a lot. Like in the middle of sea battles, arriving at port, in the middle of a city, etc.
 
lucho1392 said:
Yeah hahaha wrote that the smugling crash was fixed but still need to see if theres any random crashes ocurring. Because before that smugling problem the game just crashed a lot. Like in the middle of sea battles, arriving at port, in the middle of a city, etc.
Click to expand...
Each crash must have a specific reason, in which case they'd need separate issues on the Bug Tracker.

If there is no apparent reason, it becomes a "Random Crashes" issue, which are notoriously difficult (and virtually impossible) to fix.
We have this recent report for example: Unconfirmed Bug - Inconsistent Crash After Boarding Completes | PiratesAhoy!
 
Hello, first of all great mod thanks for that.

I've got a problem with getting my hands on coastguard plans. Everytime i'm about to get said plans my game just crashes.
I'm using build 14 beta 4 2.April 2016

And this is what my error.log looks like:
RUNTIME ERROR - file: smuggling.c; line: 962
incorrect argument index
RUNTIME ERROR - file: smuggling.c; line: 962
Bad function argument
RUNTIME ERROR - file: smuggling.c; line: 963
missed attribute: start
RUNTIME ERROR - file: smuggling.c; line: 963
no rAP data
RUNTIME ERROR - file: smuggling.c; line: 964
missed attribute: end
RUNTIME ERROR - file: smuggling.c; line: 964
no rAP data

Is there anything i can do about it?
 

Attachments

  • coastguard.jpg
    coastguard.jpg
    481.8 KB · Views: 173
I thought i'm using the latest version. I downloaded it from moddb :modding

Well i guess i have to live with it then, because i invested way too much time in this save to start over. Thank you for the quick reply though.
 
Babberdeggl said:
I thought i'm using the latest version. I downloaded it from moddb :modding
Click to expand...
You have the latest public release. The real latest version is still considered "Work In Progress".
It should, however, be objectively more playable than the ModDB version. We just haven't had the time to make a proper release of it.

Babberdeggl said:
Well i guess i have to live with it then, because i invested way too much time in this save to start over. Thank you for the quick reply though.
Click to expand...
Can you upload your PROGRAM\smuggling.c file? I wonder if it is possible to create a quick-fix.

@Grey Roger or @Jack Rackham: Could you also upload your version of the same file?
Maybe this was already fixed and that fix could be easily adapted to the 2 Apr 2016 version?
Would need to see by WinMerging both versions of the file.
 
My version will be the one from the 7th January release. But I've no idea if it works because I never do smuggling.
 

Attachments

  • smuggling.c
    68.7 KB · Views: 182
It is working, but when i get the plans, it just says: "the best time to go is." But it doesn't tell me any time.
Is that supposed to be like this?

And i just encountered a different minor problem. When i use the "sail to" option everything is fine, except the port names. It just shows #stown_name# Port.
 
Last edited:
Babberdeggl said:
It is working, but when i get the plans, it just says: "the best time to go is." But it doesn't tell me any time.
Is that supposed to be like this?
Click to expand...
The reason why it crashed is because there aren't any patrols on the island at all.
It isn't quite intentional (and should probably behave slightly better in the 7 Jan 2017 version), but you can interpret it as meaning "anything goes".
In other words: In this case, the best time is whenever you want.

Babberdeggl said:
And i just encountered a different minor problem. When i use the "sail to" option everything is fine, except the port names. It just shows #stown_name# Port.
Click to expand...
Looks like that has happened to someone else before as well:
Fixed - "#stown_name#" Showing in 3D Sailing Mode (Sail-To + Spyglass) | Page 2 | PiratesAhoy!
This is what I suggested that time as a fix:
Pieter Boelen said:
Just execute this through console and it all goes back to normal:
Code: 
SetLocalizedLabels();
Click to expand...
See here point #4 for how to do that:
Tutorial - Modding Tips & Tricks | PiratesAhoy!
 
You must log in or register to reply here.
Back
Top