Fixed GetPatrolTimeText Can Cause Crashes

[Mere_Mortal]

Free-play as a pirate, currently at Turks. Guaranteed crash if I talk to anybody other than the barman in the tavern.

RUNTIME ERROR - file: smuggling.c; line: 962
incorrect argument index
RUNTIME ERROR - file: smuggling.c; line: 962
Bad function argument
RUNTIME ERROR - file: smuggling.c; line: 963
missed attribute: start
RUNTIME ERROR - file: smuggling.c; line: 963
no rAP data
RUNTIME ERROR - file: smuggling.c; line: 964
missed attribute: end
RUNTIME ERROR - file: smuggling.c; line: 964
no rAP data

string GetPatrolTimeText(ref sisland, int best)
{
   aref patrols;
   makearef(patrols,sisland.smuggling.patrol);
   string patrol = GetAttributeName(GetAttributeN(patrols,best));
   string start = GetTimeText(stf(sisland.smuggling.patrol.(patrol).start));
   string end = GetTimeText(stf(sisland.smuggling.patrol.(patrol).end));
   string text = "between "+start+" and "+end;
   return text;
}

I placed a return at the top of the function and I can now speak to people.

 

[Pieter Boelen]

Do you have a save from which I can test this?
It may be a quick fix, but I'm not near my computer for a few days so can't look into it yet at the moment.

 

[Mere_Mortal]

It seems to depend on the dialogue options as to whether or not it crashes - I think it will if somebody will actually talk to me.
Speaking to the barman is okay, so what does appear to be consistent is spawning an officer and then attempting to talk to him.

 

[Pieter Boelen]

There should be only two types of characters who use that function in their dialog:
Officers and soldiers in the Tavern.

 

[llewelyn ravencroft]

about that every time i talk to my officers on cozumel and on the landing I get this

 

[llewelyn ravencroft]

and here are the other two logs

 

[Pieter Boelen]

about that every time i talk to my officers on cozumel and on the landing I get this

Moved your post here as it seems to be the same issue.

 

[llewelyn ravencroft]

Moved your post here as it seems to be the same issue.

thanks

 

[llewelyn ravencroft]

Pieter do you want my save?

 

[Pieter Boelen]

Pieter do you want my save?

You're welcome to post it.

 

[llewelyn ravencroft]

Here my Cozumel save

 

[Pieter Boelen]

@Mere_Mortal and @llewelyn ravencroft: I think I know why the game would crash there.
In MM's savegame, Turks is PIRATE and therefore has NO smuggling patrols defined. Likewise, there isn't much to smuggle on Cozumel either.

I think this change in PROGRAM\smuggling.c should prevent any errors due to this:

string GetPatrolTimeText(ref sisland, int best)
{
   aref patrols;
   makearef(patrols,sisland.smuggling.patrol);
   if (GetAttributesNum(patrols) > 0) // PB: Just in case there are no patrols at all
   {
     string patrol = GetAttributeName(GetAttributeN(patrols,best));
     string start  = GetTimeText(stf(sisland.smuggling.patrol.(patrol).start));
     string end  = GetTimeText(stf(sisland.smuggling.patrol.(patrol).end));
     return "between "+start+" and "+end;
   }
   return "";
}

See attached for my copy of the file.

EDIT: Confirmed, this solves the problem.

 

[Mere_Mortal]

Soldiers patrolling in pirate town would be bad for their health.

 

[Pieter Boelen]

There can actually be Smuggling patrols on pirate Islands too. But not if the Smuggling Nation of that Island is also pirate.
This is to simulate the idea that another nation may claim ownership over an island, even if they themselves have no settlement there.

 

[Mere_Mortal]

Ah, that makes a better sense. Still bad for their health, though.

 

[Pieter Boelen]

Ah, that makes a better sense. Still bad for their health, though.

If you play in Early Explorers, then often Spain is the "Smuggling Nation" for islands, even if Spain has no settlement there.
This often affects Turks. Also with England in the later time periods.

 

[lucho1392]

Hey mates been a while since last time I wrote something around here. Well have been playing the newest Mod version and it always radomly crashes. It's kind of annoying but try to avoid any stress by quicksaving a LOT.

Is this normal or is just my pc or my stock game or IDK.

Edit: Was playing in free play with Master & Commander. Now playing the main story.

Save: MEGA

 

[Pieter Boelen]

Hey mates been a while since last time I wrote something around here. Well have been playing the newest Mod version and it always radomly crashes. It's kind of annoying but try to avoid any stress by quicksaving a LOT.

What latest game version are you talking about? Post all the .log files from your main game folder after it happens.

Also, I'm moving this to the "Support" forum as without any details, this is no actual bug report.

 

[lucho1392]

Download: Build 14 Beta 4.1 WIP Part 1: Installation Wizard (Updated: 22 May 2016)
Installation: Proper installer file, use in combination with the Build 14 Beta 4.0 Part 2: Contents Archive file (Updated: 31 March 2016)
Compatibility: Works with Beta 4.0 savegames
Press F11 to reinitialize to ensure all updates take effect!

The AOP rar has my log files after the crash.

 

[Pieter Boelen]

AoP is a different game altogether.

Edit: Was playing in free play with Master & Commander. Now playing the main story.

I see attachments now, but why is there no "compile.log"? There must be one!

The error.log you show looks familiar. See here:
Fixed - GetPatrolTimeText Can Cause Crashes | PiratesAhoy!