Poll Fan's patch for "New Horizons" B14b4.1 WIP 28.07.16

[Uzver]

My bad, the version from 28 july 2016...I missed that. It is not a bad localization.
***
Spectators, do you want to play it or not? I never seen any player's opinion, so I must continue attaching my tweaks or no one cares it?

 

[Hylie Pistof]

So is this is based on an earlier, incompatible version or is it ok to install?

 

[Uzver]

The version is B14 b4.1, last update from 7.01.17...my tweaks based on update from 28.07.16. I dont think that is incompatible. The veight of PROGRAM folder is ~30mb, you may (must) easily backuping it.

 

[Pieter Boelen]

My current version is B14 b4.1 WIP

What date is shown?

By the way, add some != PLAYER_TYPE_CASTAWAY requisitions in case "Tut_start": of Storyline/freeplay/quests/both_reactions.c to prevent generation of invalid item in captain's chest. (all because of (player gun)/(player blade))

Pretty sure I did that months ago already...?

So is this is based on an earlier, incompatible version or is it ok to install?

@Uzver says it is based on the 28 July 2016 version, so it is NOT compatible with any versions that are currently available.
That version was the good and stable version until I replaced it on 7 January 2017 with a new and improved version (with great thanks to @Grey Roger!).
So it should really be merged with the latest version to avoid any compatibility issues.

 

[Uzver]

Pretty sure I did that months ago already...?

But it still creating one invalid item because of player's gun or blade.

That version was the good and stable version

I meet this game not so long ago, and I don know these details about compatibility...and if my wersion is stable, I'm afraid to imagine what kind of problems going on in last update.

 

[Captain Murphy]

@Pieter Boelen @Grey Roger @Hylie Pistof
Add this to the reasons to use a source control repo like we set up to test last year.

piratesahoy / new-horizons · GitLab

It would cut down on this problem of being different versions and not knowing where the head of the code is at.

 

[Pieter Boelen]

But it still creating one invalid item because of player's gun or blade.

Of course! Because I fixed it after 28 July 2016. So you don't have my fix yet because you have an older version, but the 7 January 2017 version does have it.

if my wersion is stable, I'm afraid to imagine what kind of problems going on in last update.

The 28 July 2016 version was indeed a very stable WIP version. There is only one version MORE stable, which is the 7 January 2017 one.
That one is fully safe to use and is the recommended version right now. Especially WITH @Grey Roger's latest ZIP included.
So technically the latest stable version is dated today.

Best thing to do is to install the latest version side-by-side with your own, then use a program like WinMerge to get them both in line.

Add this to the reasons to use a source control repo like we set up to test last year.

piratesahoy / new-horizons · GitLab

It would cut down on this problem of being different versions and not knowing where the head of the code is at.

That would absolutely solve the problem and I have been pushing for that last year.
But I have no time to set it up and/or make use of it for the foreseeable future.
Which means that nobody else is going to be using it either.
Which is a crying shame, because it is, plain and simple, a good idea.

 

[Uzver]

Maybe I should close this thread at all, if my tweaks is compatible with early version only? (or you should)

 

[Pieter Boelen]

Maybe I should close this thread at all, if my tweaks is compatible with early version only? (or you should)

Just merge them and replace the ZIP in the opening post.
That'll VASTLY increase the chances of your work being tested and included in @Grey Roger's next ZIP.
No huge changes have been done since 28 July 2016 with a focus on fixes only, so that should be relatively straightforward.

 

[Uzver]

All right then, cap! I added some new today, and it's in opening post now.

 

[Uzver]

@Grey Roger...if you read it...Forget about ReInitType system, that I was propose. I found that dammit script error! LAi_monsters > s. 704
string chrtype = fnt.chr_ai.type;____instead of____string chrtype = chr.chr_ai.type;

 

[Kilo]

Ahoy Uzver,
Thanks for your effort on your mod. I'm interested in trying out just your weather and sea changes. Back up my /Program/Weather folder and replace with yours - what other files, if any?
Thanks.

 

[Pieter Boelen]

@Kilo: Make sure you check which modpack version you are running.
If you run ANYTHING other than the 28 July 2016 version (which is fairly outdated), you'll have to be careful installing these files.
Best to use WinMerge and copy only over the relevant lines of code...

 

[Uzver]

@Kilo, if you want to try weather mod only: there is the "log2" file in "Glad to help project" thread...you'll find detailed change log and list of files there.