Fixed Confused Governor

[Cassadar]

The governor of your own colony apparently refers to his/her own gender while talking to you:



Well, either that or this woman just hates me. Not sure how I should feel about being called a mademoiselle.

 

[ANSEL]

 

[Pieter Boelen]

Thanks for reporting.

I thought I had corrected that error in most spots by now.
Apparently I missed one. Will check.

What exact game version including date are you running according to your main menu?
Could you upload a savegame in front of the wrong governor?

 

[Grey Roger]

I don't think game version is going to be all that significant because I can't see an updated version of "PROGRAM\DIALOGS\governor.c" in either the 28th July installer or @Levis' new ZIP update. So, from the 17th March version of "governor.c", line 455 onwards:

       Preprocessor_Add("addr", GetCharacterAddressForm(NPChar, ADDR_CIVIL, false, false));
       dialog.text = DLG_TEXT[70];
       link.a1 = DLG_TEXT[71];
       link.a1.go = "Colony_management";
       link.l2 = DLG_TEXT[72];
       link.l2.go = "quests";
       link.l3 = DLG_TEXT[73];
       link.l3.go = "exit";

That 'PreProcessor_Add' command is the culprit. The first argument should presumably be "PChar", not "NPChar". The governor is supposed to be addressing you, but "NPchar" is the governor.

 

[Levis]

@Grey Roger In one of the dialog options I believe the addr is also called. So i believe this case two seperate ones need to be made. one for the govenor and one for the player.

 

[Pieter Boelen]

Indeed that does sound likely.

For the correct addresss form of the player TO another character, there is a different function; GetMyCharacterAddressForm, I believe.

 

[Grey Roger]

@Grey Roger In one of the dialog options I believe the addr is also called. So i believe this case two seperate ones need to be made. one for the govenor and one for the player.

Yes, dialog text line 70 uses "addr" and is the governor talking to you ("What are your orders, #saddr#?"), while line 72 also uses "addr" for you talking to the governor ("Do you need assistance, #saddr#?"). Different variable will indeed be needed.

 

[Levis]

@Pillat maybe you can look at this one? it's described what should be done just someone needs to do it and check it

If you want to help modding again ofc. else no problem .

 

[KillPhil]

That doesnt sound like just copying and testing.. I don't think I am into the stormcode that far anymore, I am sorry . I can edit textfiles and change some numbers, but adding new stuff.. I dont think I would be much of a help here I'm afraid :/

 

[Pieter Boelen]

Maybe @Grey Roger could do it?
It should not be a great amount of work, really.

 

[Grey Roger]

Indeed that does sound likely.

For the correct addresss form of the player TO another character, there is a different function; GetMyCharacterAddressForm, I believe.

'string GetMyAddressForm(ref chr, ref pchr, int addrtype, bool fname, bool lname)' perhaps?

If so, then replacing that section of "PROGRAM\DIALOGS\governor.c" with this:

       Preprocessor_Add("addr1", GetMyAddressForm(NPChar, ADDR_CIVIL, false, false));
       Preprocessor_Add("addr2", GetCharacterAddressForm(NPChar, PChar, ADDR_CIVIL, false, false));
       dialog.text = DLG_TEXT[70];
       link.a1 = DLG_TEXT[71];
       link.a1.go = "Colony_management";
       link.l2 = DLG_TEXT[72];
       link.l2.go = "quests";
       link.l3 = DLG_TEXT[73];
       link.l3.go = "exit";

And lines 72-74 in "PROGRAM\DIALOGS\ENGLISH\governor.h" (which equates to DLG_TEXT[70] - DLG_TEXT[72]) with this:

"What are your orders, #saddr1#?",
"I must manage this colony.",
"Do you need any assistance, #saddr2#?",

should do the job. But I won't be able to test it myself for a while - in fact, as testing it requires capturing a colony and I'm in no position to do that in any current savegame, I won't be able to test it myself for a very long time... So if anyone else wants to try it out, the files are attached.

 

[Pieter Boelen]

@Cassadar, do you have a savegame with your captured colony?
That should be the quickest way to test if @Grey Roger's fix works as intended.

'string GetMyAddressForm(ref chr, ref pchr, int addrtype, bool fname, bool lname)' perhaps?

Yep, that's the one!

'GetMyAddressForm' is for NPC to Player, while 'GetCharacterAddressForm' is for Player to NPC.

 

[Cassadar]

@Cassadar, do you have a savegame with your captured colony?
That should be the quickest way to test if @Grey Roger's fix works as intended.

That savegame doesn't exist anymore, because the lack of music made me so sad. I can capture it again though. One moment please.

 

[Pieter Boelen]

That savegame doesn't exist anymore, because the lack of music made me so sad.

I think that will be easily fixed. As long as we find something suitable to put into place.
Should not be a big issue.

I can capture it again though. One moment please.

 

[Cassadar]

Works like a charm. Thanks @Grey Roger

 

[Cassadar]

Huh, I forgot this one:


Works also with female characters of course.

 

[Pieter Boelen]

"My name is a damsel in distress"??? Does that go OK?

 

[Cassadar]

Why not? I think her parents were just cruel.

 

[Grey Roger]

Very cruel. Her first name seems to be " a". Including the leading space, which confused me for a moment because I thought this was a dialog string saying "a damsel in distress" and a dialog code going wrong and failing to display something. A complete and total lack of "damsel in distress" in any dialog text file indicated that this was probably not the case.

 

[Pieter Boelen]

Why not? I think her parents were just cruel.

Seems you got me fooled there!