• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Fixed Claire Larrouse Issues

There should indeed be fake crew. And still no ship?
Sounds like my attempt at fixing this failed. :(
 
Fake crew were only in standard storyline characters\init\story so weren't placed in freeplay (and probably other storylines eg Jack Sparrow). Have moved them to program\characters\init \officers so they are available everywhere.

Clair and Claire shared the same character ID so I thought that might be it - when one is killed the other one is affected, but that didn't see the ship appear -still looking at that.
 
They share the same character ID???
That doesn't make sense; I thought I replaced Claire's ID to actually have an "e" after her name.
She didn't before, but should do now everywhere! :shock
 
I just did Claire in free play and when I double crossed her and then went to sea her ship was missing with the message that character ID Clair Larousse was missing.
 

Attachments

  • POTC4 2015-11-02 12-18-30-58.jpg
    POTC4 2015-11-02 12-18-30-58.jpg
    196.4 KB · Views: 184
Agh, I think I got it ALMOST right with my code then. In PROGRAM\Characters\init\SideQuest.c, this line:
Code: 
ch.id     = "Claire Larrouse";
Should have been this:
Code: 
ch.id     = "Clair Larrouse";
:facepalm
 
Last edited:
Corrected now! Dammit, I know for absolute certain that I DID, in fact, remove that "e" the first time around!!! :boom:
 
Pieter Boelen said:
Agh, I think I got it ALMOST right with my code then. In PROGRAM\Characters\init\SideQuest.c, this line:
Code: 
ch.id     = "Claire Larrouse";
Should have been this:
Code: 
ch.id     = "Clair Larrouse";
:facepalm
Click to expand...

Yes indeed that is the duplicate ch.id I was referring to.

I have now got a ship there when you double cross claire. I have altered the male counterpart name to be Claire's First_Officer because he looks odd fighting under the name clair and if you keep him for ransom etc. I have also ensured that he gets all the gold when you can't agree with claire on the split - so you don't get any until you take the ship -but if you disagree before the final scene you just get the ship (since you don't go after the gold). I have as I said before put the fake crew into characters\init \sidequest rather than standard story so they occur in all storylines. I have also tweaked the final questbook to say fight with her crew rather than kill, because you don't kill them all (particularly if you accept Claire's First Officer surrender which occurs from time to time). So here are my five files for you to see how they compare. I think this all works now

EDIT except there are still a couple of missing vskip locations where you can meet bandits/townspeople in the jungle.
 

Attachments

  • claire.7z
    55 KB · Views: 192
Last edited:
Actually still a couple of problems (minor I guess). If you fight Claire on land on either occasion but then run from her ship you never get to escape - the world map doesn't appear and you just sail on to nowhere (and I guess the quest remains open). Also if you don't agree to continue from the canyon when you return to the lighthouse the ships have gone (an earlier fix by @Pieter Boelen for them not being at grey rock bay), so you have to fast travel to the deck (or presumably run all the way to grey rock bay although there's nothing to tell you that's where the ships are. Not a great problem since I doubt anyone would back out at that point but..

Also naming Claire's First Officer leaves him as the man with no name (other than that) if you hire him as an officer if he surrenders. So perhaps better just to give him a name and leave his role on board Cheri as unspecified?

I'll probably still look at these points but I'm away for a fortnight so don't hold your breath
 
I named the first officer Clair in honour of him being a guy in the original game.
Figured he could be her uncle or something; family business.

Thanks @pedrwyth! :cheers
 
:ahoy
So I have added two cases to close off the quest if you run from Clair's ship, one with the gold and one without and have removed Clair's ship so it's not hanging round Barbados indefinitely if you do sail away. I assume from another thread that map enter as a condition for this is ok for 3d sailing too?


I have placed the ships at the lighthouse at the start in case you give up in the canyon. :keith

I have added a close quest for the scenario that you allow the convey to escape on catching it (however unlikely it is to occur) - and the ships are still at the lighthouse at that point so you can fast travel or make your way back to them.

I have altered the dialogue that stated that the ships are not yet at Grey Rock Bay when you arrive - because the altered code placing them there means they are! Without a further reload I can't get them to arrive during your time at the shore but the dialogue now copes with that.

I have reverted all the gold to be on the shore because why would you let it be loaded onto Clair's ship - so you get it all if you double cross Claire even without taking her/his ship.

Finally have restored the ship captain Clair Larrousse as her uncle/cousin or whatever as per @Pieter Boelen 's original intention. :wp

so NOW I think (hope) it is finally fixed (except it isn't adapted for non English Barbados in the early period) :shrug

My attempt at placing the Cheri generates an error log but the ship is there in both scenes - altering the generic oxbay to the actual location (lighthouse or shore2) seems to stop the ship from showing up so I heve left it as is for now.

Here are the affected files
 

Attachments

  • claire2.7z
    52.8 KB · Views: 193
Thanks a lot! :woot

pedrwyth said:
I assume from another thread that map enter as a condition for this is ok for 3d sailing too?
Click to expand...
It should be. :yes

pedrwyth said:
Finally have restored the ship captain Clair Larrousse as her uncle/cousin or whatever as per @Pieter Boelen 's original intention. :wp
Click to expand...
It was merely a suggestion. :shrug

pedrwyth said:
My attempt at placing the Cheri generates an error log but the ship is there in both scenes - altering the generic oxbay to the actual location (lighthouse or shore2) seems to stop the ship from showing up so I heve left it as is for now.
Click to expand...
What error is that?
 
Pieter Boelen said:
What error is that?
Click to expand...

As posted before (and working) it is in compile.log as follows
Code: 
SEA: Error: Group Clair Larrouse, Island Oxbay
SEA: Error: Find locators Group ships_other, Locator ship3

having tried "Oxbay_lighthouse" (where I can clearly see ships_other, ship3) I now have "","" in the code which gives

Code: 
SEA: Error: Group Clair Larrouse, Island Oxbay
SEA: Error: Find locators Group , Locator

in compile.log and it still ends up with Cheri where required.
 
@pedrwyth: I think you're inputting the SHORE locator names. You need an existing locator from the island for 3D sailing mode.
I think you can pick from any of these ones:
Code: 
Reload,reload_1,-0.7986355,0,-0.601815,0,1,0,0.601815,0,-0.7986355,-15.04061,0,-77.41786,1,0,0,0,0,0,0,0,0,
Reload,reload_2,-0.4584632,0,0.8887134,0,1,0,-0.8887134,0,-0.4584632,-1542.89,-2.910383E-13,953.6416,1,0,0,0,0,0,0,0,0,
Reload,reload_3,0.9202088,0,-0.3914279,0,1,0,0.3914279,0,0.9202088,-450.4702,-2.910383E-13,772.2742,1,0,0,0,0,0,0,0,0,
Reload,reload_4,-0.8417642,0,-0.5398455,0,1,0,0.5398455,0,-0.8417642,-1052.746,-2.910383E-13,-588.3696,1,0,0,0,0,0,0,0,0,
Reload,reload_fort1,-0.3475576,0,-0.9376587,0,1,0,0.9376587,0,-0.3475576,-128.3287,45.14115,-4.020751,1,0,0,0,0,0,0,0,0,
Reload,reload_fort2,-0.4584632,0,0.8887134,0,1,0,-0.8887134,0,-0.4584632,-1490.159,21.42383,1059.158,1,0,0,0,0,0,0,0,0,
Reload,reload_5,-0.5735765,0,0.8191521,0,1,0,-0.8191521,0,-0.5735765,-1757.521,-2.910383E-13,-379.8812,1,0,0,0,0,0,0,0,0,
reload_1,ship1,-0.6430284,0,-0.7658423,0,1,0,0.7658423,0,-0.6430284,33.09996,0,-60.53808,1,0,0,0,0,0,0,0,0,
reload_1,ship2,-0.9865956,0,-0.163184,0,1,0,0.163184,0,-0.9865956,185.1083,0,-100.2148,1,0,0,0,0,0,0,0,0,
reload_1,ship3,-0.9993909,0,-0.03489692,0,1,0,0.03489692,0,-0.9993909,130.5589,0,-12.10358,1,0,0,0,0,0,0,0,0,
reload_1,ship4,-0.4389695,0,-0.898502,0,1,0,0.898502,0,-0.4389695,-0.393407,0,-152.2584,1,0,0,0,0,0,0,0,0,
reload_1,ship5,-0.9997557,0,-0.02210486,0,1,0,0.02210486,0,-0.9997557,125.3355,0,-149.682,1,0,0,0,0,0,0,0,0,
reload_1,ship6,-0.802476,0,-0.5966843,0,1,0,0.5966843,0,-0.802476,-24.34117,0,-247.4604,1,0,0,0,0,0,0,0,0,
reload_1,ship7,-0.9012806,0,0.4332358,0,1,0,-0.4332358,0,-0.9012806,92.34755,0,-242.9865,1,0,0,0,0,0,0,0,0,
reload_1,ship8,-0.9881921,0,-0.1532199,0,1,0,0.1532199,0,-0.9881921,6.654895,0,-316.2172,1,0,0,0,0,0,0,0,0,
reload_2,ship1,-0.715766,0,0.6983402,0,1,0,-0.6983402,0,-0.715766,-1523.566,-2.910383E-13,975.9875,1,0,0,0,0,0,0,0,0,
reload_2,ship2,-0.298252,0,0.9544872,0,1,0,-0.9544872,0,-0.298252,-1537.469,-2.910383E-13,925.0282,1,0,0,0,0,0,0,0,0,
reload_2,ship3,-0.550889,0,0.8345786,0,1,0,-0.8345786,0,-0.550889,-1563.526,-2.910383E-13,1012.922,1,0,0,0,0,0,0,0,0,
reload_2,ship4,-0.9981224,0,-0.06125113,0,1,0,0.06125113,0,-0.9981224,-1610.269,-2.910383E-13,955.7673,1,0,0,0,0,0,0,0,0,
reload_2,ship5,0.3080954,0,0.9513555,0,1,0,-0.9513555,0,0.3080954,-1487.461,-2.910383E-13,901.6223,1,0,0,0,0,0,0,0,0,
reload_2,ship6,0.6398936,0,0.7684636,0,1,0,-0.7684636,0,0.6398936,-1551.985,-2.910383E-13,869.4728,1,0,0,0,0,0,0,0,0,
reload_2,ship7,0.6211244,0,0.783712,0,1,0,-0.783712,0,0.6211244,-1593.93,-2.910383E-13,911.3261,1,0,0,0,0,0,0,0,0,
reload_2,ship8,0.2030847,0,0.9791611,0,1,0,-0.9791611,0,0.2030847,-1635.876,-2.910383E-13,932.6357,1,0,0,0,0,0,0,0,0,
reload_3,ship_1,0.6711547,0,-0.7413174,0,1,0,0.7413174,0,0.6711547,-430.104,-2.910383E-13,763.9181,1,0,0,0,0,0,0,0,0,
reload_3,ship_2,0.9297574,0,-0.3681729,0,1,0,0.3681729,0,0.9297574,-469.0525,-2.910383E-13,808.1312,1,0,0,0,0,0,0,0,0,
reload_3,ship_3,0.6852856,0,-0.7282745,0,1,0,0.7282745,0,0.6852856,-432.1193,-2.910383E-13,875.0499,1,0,0,0,0,0,0,0,0,
reload_3,ship_4,0.5766555,0,-0.8169874,0,1,0,0.8169874,0,0.5766555,-401.4522,-2.910383E-13,842.459,1,0,0,0,0,0,0,0,0,
reload_3,ship_5,0.77736,0,-0.629056,0,1,0,0.629056,0,0.77736,-376.0488,-2.910383E-13,806.4683,1,0,0,0,0,0,0,0,0,
reload_3,ship_6,0.4297722,0,-0.9029374,0,1,0,0.9029374,0,0.4297722,-287.8711,-2.910383E-13,889.8614,1,0,0,0,0,0,0,0,0,
reload_3,ship_7,0.8764642,0,-0.4814669,0,1,0,0.4814669,0,0.8764642,-383.1331,-2.910383E-13,956.7609,1,0,0,0,0,0,0,0,0,
reload_3,ship_8,0.8061972,0,-0.5916469,0,1,0,0.5916469,0,0.8061972,-305.0952,-2.910383E-13,975.0969,1,0,0,0,0,0,0,0,0,
reload_4,ship_1,-0.9892949,0,-0.1459297,0,1,0,0.1459297,0,-0.9892949,-1093.857,-2.910383E-13,-597.4006,1,0,0,0,0,0,0,0,0,
reload_4,ship_2,-0.9963585,0,0.08526359,0,1,0,-0.08526359,0,-0.9963585,-1175.109,-2.910383E-13,-693.8421,1,0,0,0,0,0,0,0,0,
reload_4,ship_3,-0.9144044,0,-0.4048019,0,1,0,0.4048019,0,-0.9144044,-1091.57,-2.910383E-13,-700.9909,1,0,0,0,0,0,0,0,0,
reload_4,ship_4,-0.8099463,0,-0.586504,0,1,0,0.586504,0,-0.8099463,-1021.714,-2.910383E-13,-670.0657,1,0,0,0,0,0,0,0,0,
reload_4,ship_5,-0.8099463,0,-0.586504,0,1,0,0.586504,0,-0.8099463,-953.436,-2.910383E-13,-656.4114,1,0,0,0,0,0,0,0,0,
reload_4,ship_6,-0.9328071,0,-0.360376,0,1,0,0.360376,0,-0.9328071,-1022.7,-2.910383E-13,-768.2406,1,0,0,0,0,0,0,0,0,
reload_4,ship_7,-0.9950734,0,0.09914055,0,1,0,-0.09914055,0,-0.9950734,-1120.053,-2.910383E-13,-805.8515,1,0,0,0,0,0,0,0,0,
reload_4,ship_9,-0.6301988,0,-0.7764338,0,1,0,0.7764338,0,-0.6301988,-941.8531,-2.910383E-13,-748.5579,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_1,0.9702957,0,-0.2419219,0,1,0,0.2419219,0,0.9702957,-122.2998,0,-736.8705,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_2,0.2805463,0,0.9598405,0,1,0,-0.9598405,0,0.2805463,371.0182,0,-558.4962,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_3,-0.116938,0,0.9931392,0,1,0,-0.9931392,0,-0.116938,263.5136,0,-926.3045,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_4,-0.116938,0,0.9931392,0,1,0,-0.9931392,0,-0.116938,-1161.567,0,-1094.102,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_5,0.08365279,0,0.9964949,0,1,0,-0.9964949,0,0.08365279,-951.1236,0,-1217.246,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_6,-0.2671984,0,0.9636415,0,1,0,-0.9636415,0,-0.2671984,-607.795,0,-830.1198,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_7,-0.9509485,0,0.3093491,0,1,0,-0.3093491,0,-0.9509485,-1901.719,0,982.6564,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_8,-0.6412059,0,-0.7673689,0,1,0,0.7673689,0,-0.6412059,-1840.078,0,843.8105,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_9,0.9120846,0,0.410002,0,1,0,-0.410002,0,0.9120846,-1921.167,0,699.4753,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_10,-0.9330032,0,-0.3598679,0,1,0,0.3598679,0,-0.9330032,-223.5423,0,1306.651,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_11,-0.9065443,0,0.4221107,0,1,0,-0.4221107,0,-0.9065443,0.1001767,0,1295.768,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_12,-0.3938588,0,-0.919171,0,1,0,0.919171,0,-0.3938588,-9.770738,0,1491.667,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_13,-0.9643337,0,-0.2646894,0,1,0,0.2646894,0,-0.9643337,916.0416,0,478.7604,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_14,-0.9908725,0,0.1348023,0,1,0,-0.1348023,0,-0.9908725,832.0254,0,-335.8969,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_15,-0.9990885,0,-0.04268826,0,1,0,0.04268826,0,-0.9990885,-2179.637,0,73.82172,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_16,-0.9709544,0,-0.2392646,0,1,0,0.2392646,0,-0.9709544,-2367.504,0,-729.5959,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_17,0.01896821,0,-0.9998201,0,1,0,0.9998201,0,0.01896821,-1810.187,0,-1703.16,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_18,-0.3710936,0,-0.9285955,0,1,0,0.9285955,0,-0.3710936,-1197.558,0,-976.3898,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_19,-0.3710936,0,-0.9285955,0,1,0,0.9285955,0,-0.3710936,-1067.975,0,-933.1069,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_20,-0.6610084,0,0.7503785,0,1,0,-0.7503785,0,-0.6610084,-893.738,0,-909.5319,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_21,0.1118217,0,0.9937283,0,1,0,-0.9937283,0,0.1118217,-772.7004,0,-802.9099,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_22,0.8660254,0,0.5,0,1,0,-0.5,0,0.8660254,142.4114,0,-516.317,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_23,0.9205049,0,-0.3907311,0,1,0,0.3907311,0,0.9205049,-18.9111,0,-498.1638,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_24,0.5877852,0,-0.809017,0,1,0,0.809017,0,0.5877852,-124.8083,0,-488.8133,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_25,0.9925461,0,-0.1218693,0,1,0,0.1218693,0,0.9925461,58.92059,0,-662.2235,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_26,-0.37696,0,-0.9262295,0,1,0,0.9262295,0,-0.37696,-190.8468,0,1502.117,1,0,0,0,0,0,0,0,0,
Quest_ships,quest_ship_27,-0.9509485,0,0.3093491,0,1,0,-0.3093491,0,-0.9509485,-2029.145,0,886.5894,1,0,0,0,0,0,0,0,0,
reload_5,ship1,-0.5735765,0,0.8191521,0,1,0,-0.8191521,0,-0.5735765,-1757.521,-2.910383E-13,-379.8812,1,0,0,0,0,0,0,0,0,
reload_5,ship2,-0.9848077,0,0.1736482,0,1,0,-0.1736482,0,-0.9848077,-1899.233,-2.910383E-13,-206.9704,1,0,0,0,0,0,0,0,0,
reload_5,ship3,-0.8191521,0,0.5735765,0,1,0,-0.5735765,0,-0.8191521,-1940.121,-2.910383E-13,-438.8543,1,0,0,0,0,0,0,0,0,
reload_5,ship4,0.9205049,0,0.3907311,0,1,0,-0.3907311,0,0.9205049,-1991.692,-2.910383E-13,-269.9823,1,0,0,0,0,0,0,0,0,
reload_5,ship5,0.9925461,0,-0.1218693,0,1,0,0.1218693,0,0.9925461,-2040.398,-2.910383E-13,-135.4476,1,0,0,0,0,0,0,0,0,
reload_5,ship6,0.9925461,0,-0.1218693,0,1,0,0.1218693,0,0.9925461,-2152.442,-2.910383E-13,-364.3618,1,0,0,0,0,0,0,0,0,
reload_5,ship7,0.9063078,0,0.4226183,0,1,0,-0.4226183,0,0.9063078,-2237.788,-2.910383E-13,-220.2815,1,0,0,0,0,0,0,0,0,
reload_5,ship9,0.656059,0,0.7547096,0,1,0,-0.7547096,0,0.656059,-2251.949,-2.910383E-13,-533.9141,1,0,0,0,0,0,0,0,0,
If I recall, @Grey Roger had some queries about something similar earlier this week.
See here for details: http://www.piratesahoy.net/posts/521995/
 
Yes, and it turns out the sea locator is visible, once I move to a place where it's not being obscured by my own ship! I used one of them to place a ship and it worked.

Another trick, which I borrowed from the "Strange Things Going On" quest and which also worked, is to put the ship where you are:
Code: 
      Group_CreateGroup("Mefisto");
       Group_AddCharacter("Mefisto", "Dark Captain");
       Group_SetGroupCommander("Mefisto", "Dark Captain");
       Group_SetPursuitGroup("Mefisto", PLAYER_GROUP);
       Group_SetTaskAttack("Mefisto", PLAYER_GROUP, true);
       Group_SetAddress("Mefisto", Characters[GetMainCharacterIndex()].location, "", "");
Note that "Mefisto" here isn't the name of the ship, it's the name of the group to which the ship had previously been assigned.
 
Grey Roger said:
Another trick, which I borrowed from the "Strange Things Going On" quest and which also worked, is to put the ship where you are:
Code: 
      Group_CreateGroup("Mefisto");
       Group_AddCharacter("Mefisto", "Dark Captain");
       Group_SetGroupCommander("Mefisto", "Dark Captain");
       Group_SetPursuitGroup("Mefisto", PLAYER_GROUP);
       Group_SetTaskAttack("Mefisto", PLAYER_GROUP, true);
       Group_SetAddress("Mefisto", Characters[GetMainCharacterIndex()].location, "", "");
Note that "Mefisto" here isn't the name of the ship, it's the name of the group to which the ship had previously been assigned.
Click to expand...
Not sure if you even need to do use Group_SetAddress at all. Find the "Convoy Pirate" in quests_common.c or "Treasure Pirate" in MAXIMUS_functions.c .
Those are always generated near the player ship too. I cannot check right now, but I don't remember them having their position specifically set, so then the game then puts them "near you".
 
You must log in or register to reply here.
Back
Top