We're about to get started on making quite some large changes to everything dealing to player actions and nation relations.
Full overview of our current intentions can be found here: http://www.piratesahoy.net/threads/change-in-nation-relations-from-player-actions.25514/
Players will of course need to know about these changes when playing as well.
So how are we going to handle this in such a way that people won't get needlessly confused?
Here are some thoughts of mine:
The governor.c dialog file contains a case "international relations".
At the moment that makes him tell you all nations they are hostile with. This should be expanded to also mention the nations they are allied with.
I wonder if this dialog option should be available to ALL players or only to those who have a LoM from that nation or are in their navy?
"Served Nation" is used to define where your alliances lie.
At the moment this affects mainly which nations' relation changes you will follow in Free Play.
But soon this will also affect what flag you'll hoist when you are recognized for flying false colours.
In other words, this will be quite important but at the moment it isn't communicated to the player.
Does anyone have any thoughts on where we can fit this into the interfaces?
Ideally the F2>Characters or F2>Nation Relations one would be the most appropriate, I reckon.
Your nation relation text turns GREEN when you can be promoted.
I want to change this so it only does that if you can ACCEPT that promotion because you actually have a LoM.
So if for whatever reason, you DO have a number higher than 0 for any nation, it should still not turn green if you don't have a LoM there.
--------------------------
And then some queries on the coding side:
There is an ENABLE_FLAGS toggle that is used in many parts of the code and controls whether you can make use of false flags or not.
This is, of course, always true as I do not know why anyone would want the feature to not be there.
And if we truly DO want to prevent it, we should be able to just disable the button and leave the nation relation systems as-is.
This has also created pretty much TWO systems for nation relations that probably isn't making things any simpler either.
I'm not even sure if ALL code always takes this toggle into account where necessary.
In other words: The game might not even work normally anymore if this is set to false.
On the other hand, we DO have a wide range of different players who enjoy our game.
Now that we'll potentially be making the nation relations more complicated than they ever were before, do we need to maintain some sort of "simple mode".
If so, what kind of simplifications would be in order? And should that be linked to Arcade Game Mode or get its own toggle?
@Jason, do you happen to have any ideas?
It appears that a lot of the nation relation code is linked to specific governor characters.
However, I have no clue why that is the case and it sounds to me like that is quite a needless complication as we care about nations as a whole, don't we?
So I propose getting rid of everything related to this to prevent any confusion arising from it.
Actually, looking at nations.c, I see a LOT of apparently convoluted code and perhaps we ought to REALLY redo it all pretty much from scratch.
Perhaps we should leave that amount of cleaning up for Build 15 though as I do fear there is a risk of breaking things there.
On the other hand, we can probably simplify things quite substantially too.
@Levis: If you're wondering, I'm making separate threads for different parts of this functionality as this is quite a complex one and I'd like to keep a bit of an overview.
Full overview of our current intentions can be found here: http://www.piratesahoy.net/threads/change-in-nation-relations-from-player-actions.25514/
Players will of course need to know about these changes when playing as well.
So how are we going to handle this in such a way that people won't get needlessly confused?
Here are some thoughts of mine:
The governor.c dialog file contains a case "international relations".
At the moment that makes him tell you all nations they are hostile with. This should be expanded to also mention the nations they are allied with.
I wonder if this dialog option should be available to ALL players or only to those who have a LoM from that nation or are in their navy?
"Served Nation" is used to define where your alliances lie.
At the moment this affects mainly which nations' relation changes you will follow in Free Play.
But soon this will also affect what flag you'll hoist when you are recognized for flying false colours.
In other words, this will be quite important but at the moment it isn't communicated to the player.
Does anyone have any thoughts on where we can fit this into the interfaces?
Ideally the F2>Characters or F2>Nation Relations one would be the most appropriate, I reckon.
Your nation relation text turns GREEN when you can be promoted.
I want to change this so it only does that if you can ACCEPT that promotion because you actually have a LoM.
So if for whatever reason, you DO have a number higher than 0 for any nation, it should still not turn green if you don't have a LoM there.
--------------------------
And then some queries on the coding side:
There is an ENABLE_FLAGS toggle that is used in many parts of the code and controls whether you can make use of false flags or not.
This is, of course, always true as I do not know why anyone would want the feature to not be there.
And if we truly DO want to prevent it, we should be able to just disable the button and leave the nation relation systems as-is.
This has also created pretty much TWO systems for nation relations that probably isn't making things any simpler either.
I'm not even sure if ALL code always takes this toggle into account where necessary.
In other words: The game might not even work normally anymore if this is set to false.
On the other hand, we DO have a wide range of different players who enjoy our game.
Now that we'll potentially be making the nation relations more complicated than they ever were before, do we need to maintain some sort of "simple mode".
If so, what kind of simplifications would be in order? And should that be linked to Arcade Game Mode or get its own toggle?
@Jason, do you happen to have any ideas?
It appears that a lot of the nation relation code is linked to specific governor characters.
However, I have no clue why that is the case and it sounds to me like that is quite a needless complication as we care about nations as a whole, don't we?
So I propose getting rid of everything related to this to prevent any confusion arising from it.
Actually, looking at nations.c, I see a LOT of apparently convoluted code and perhaps we ought to REALLY redo it all pretty much from scratch.
Perhaps we should leave that amount of cleaning up for Build 15 though as I do fear there is a risk of breaking things there.
On the other hand, we can probably simplify things quite substantially too.

@Levis: If you're wondering, I'm making separate threads for different parts of this functionality as this is quite a complex one and I'd like to keep a bit of an overview.
