Fixed Transfer Main Interface Error Log

[Talisman]

I got these error logs.



PS - This is not the Ransack interface - it is the transfer between ships in the shipyard one.

 

[Mere_Mortal]

When you say shipyard, you mean the “select ship” screen? The transfer crew interface is the same if it’s ransack or not.

As for the bad stats, that’s to do with unique ships. I think Pieter made a related fix for the shipyard, I need to look into it.

 

[Talisman]

When you say shipyard, you mean the “select ship” screen? The transfer crew interface is the same if it’s ransack or not.

I mean - in shipyard press F2 > ships > transfer between Ships -- then select the 2 ships to transfer between.

Wondered if it might be because the ship in @Pieter Boelen 's code above is the Cursed Dutchman & PIRATE -- Pirates are currently hostile to me.

 

[Pieter Boelen]

Pirates hostile should not affect the shipyard nor ship transfer.

 

[Mere_Mortal]

The Cursed Dutchman is a unique ship - there is (or was, and evidently is now with the new icons on the transfer screen) a problem displaying the stats properly, probably because they’re never set on the character since unique ships don’t get the nation multipliers. I think they should be set anyway on the character with the base values, that would maybe avoid such errors altogether.

 

[Pieter Boelen]

Indeed if that does not currently happen, it would be better if it did.

 

[Mere_Mortal]

I’ll have a look at it, I’m wondering if this could affect ship upgrades if the stats aren’t being set properly.

 

[Pieter Boelen]

@Talisman: I think that is an error on some new functionality that was added in the Beta 4.1 WIP.

I'd suggest the following as a fix:

void WasChangeData()
{
   ref shipRef = GetShipByType(GetCharacterShipType(refMyCharacter)); // PS
   aref arship; makearef(arship, refMyCharacter.ship); // PRS3
   GameInterface.pictures.myShip.tex  = GetShipTextureName(sti(shipRef.index)); // PS
   GameInterface.pictures.myShip.pic  = GetShipPicName(sti(shipRef.index)); // PS
   GameInterface.strings.MyShipType  = XI_ConvertString(shipRef.Sname); // PS
   GameInterface.strings.MyShipName  = refMyCharacter.ship.Name;
   GameInterface.strings.MyMaxHull  = GetCharacterShipHP(&refMyCharacter); // PRS3
   GameInterface.strings.MyHull  = MakeInt(refMyCharacter.ship.HP);
   GameInterface.strings.MyRig  = MakeInt(refMyCharacter.ship.SP);
   GameInterface.strings.MyShipSpeed  = FloatToString(stf(GetLocalShipAttrib(arship, &shipRef, "SpeedRate")),2); // PB
   GameInterface.strings.MyShipManeuver  = FloatToString(stf(GetLocalShipAttrib(arship, &shipRef, "TurnRate" )),2); // PB
   //GameInterface.strings.MyCrew  = MakeInt(refMyCharacter.ship.Crew.Quantity)+"/"+GetMaxCrewQuantity(&refMyCharacter); // PRS3
   GameInterface.strings.MyCrew  = MakeInt(refMyCharacter.ship.Crew.Quantity); // MM
   GameInterface.strings.MyCannons  = GetLocalShipAttrib(arship, &shipRef, "CurCanQty"); //NK can qty 05-04-18 shipRef.CannonsQuantity;
   //GameInterface.strings.Mincrewus  = XI_ConvertString("Min Crew") + ": " + GetMinCrewQuantity(&refMyCharacter); // PRS3
   GameInterface.strings.Mincrewus  = "Min/Max Crew: "+GetMinCrewQuantity(&refMyCharacter)+" / "+GetMaxCrewQuantity(&refMyCharacter); // MM

   shipRef = GetShipByType(GetCharacterShipType(refEnemyCharacter)); // PS
   makearef(arship, refEnemyCharacter.ship); // PRS3
   GameInterface.pictures.enemyShip.tex  = GetShipTextureName(sti(shipRef.index)); // PS
   GameInterface.pictures.enemyShip.pic  = GetShipPicName(sti(shipRef.index)); // PS
   GameInterface.strings.EnemyShipType  = XI_ConvertString(shipRef.Sname); // PS
   GameInterface.strings.EnemyShipName  = refEnemyCharacter.ship.Name;
   GameInterface.strings.EnemyMaxHull  = GetCharacterShipHP(&refEnemyCharacter); // PRS3
   GameInterface.strings.EnemyHull  = MakeInt(refEnemyCharacter.ship.HP);
   GameInterface.strings.EnemyRig  = MakeInt(refEnemyCharacter.ship.SP);
   GameInterface.strings.EnemyShipSpeed  = FloatToString(stf(GetLocalShipAttrib(arship, &shipRef, "SpeedRate")),2); // PB
   GameInterface.strings.EnemyShipManeuver = FloatToString(stf(GetLocalShipAttrib(arship, &shipRef, "TurnRate" )),2); // PB
   //GameInterface.strings.EnemyCrew  = makeint(refEnemyCharacter.ship.Crew.Quantity)+"/"+GetMaxCrewQuantity(&refEnemyCharacter); // PRS3
   GameInterface.strings.EnemyCrew  = makeint(refEnemyCharacter.ship.Crew.Quantity); // MM
   GameInterface.strings.EnemyCannons  = GetLocalShipAttrib(arship, &shipRef, "CurCanQty"); //NK can qty 05-04-18 shipRef.CannonsQuantity;
   //GameInterface.strings.Mincrewthem  = XI_ConvertString("Min Crew") + ": " + GetMinCrewQuantity(&refEnemyCharacter); // PRS3
   GameInterface.strings.Mincrewthem  = "Min/Max Crew: "+GetMinCrewQuantity(&refEnemyCharacter)+" / "+GetMaxCrewQuantity(&refEnemyCharacter); // MM
}

See the lines marked "PB".

This makes the interface behaviour here identical to the Shipyard Interface.

 

[Pieter Boelen]

Extract attached to PROGRAM\INTERFACE to use this fix.

Also contains the same fix for a similar section of code in Ransack Main.
Additionally, I changed some reference variables in that second file to get everything in line there.
I think that is what it was meant to do. @Mere_Mortal should probably double-check though.

 

[Mere_Mortal]

Seems to have done the trick.

 

[Pieter Boelen]

Seems to have done the trick.

Fixed then!

 

[Pieter Boelen]

This now included in here: Mod Release - Build 14 Beta 4.1 WIP | PiratesAhoy!