I am trying to clean up the surrender toggle in the code, or lack of. I am trying to fathom what point is calculating the morale of 'other ships' in the game, when surrender is turned off in BS.h?
It looks like all this figuring is going on for morale, just to figure if a ship should surrender to you or not. Really, this could have been done differently... not calculating EVERY ships distance, every ships strength, every ships condition, every ships state, every ships nation, blah blah blah blah, and every ships own paint job. Only needed to be concerned with YOUR ship, and if you are a better match for them. When has a ship ever surrendered to another NPC ship? I havnt seen that happen, so why all this calculation of each ship to each and every other ship, when only they ever surrender to you or not?
Other ships don't continue to exist in the world, and morale doesn't change their effectiveness in battle. So, why were there not code added to simply ignore all these calculations when surrender was turned off? This is what I'm fixing.
However, I wanted to know if I am not seeing some other use that all this morale calcing is used for on NPC ships?
And btw, who is "NK".
I am not trying to be offensive on this one. I am just doing this because it is squarely related to this code, why I have the crappiest performance during sailing in Post Build Mod 12. I dont care about surrenders, and as such, all this code is doing nothing for me but make the sailing in game unplayable. So, a proper toggle, will save me much time and effort in the future commenting all this code out in each new update.
It looks like all this figuring is going on for morale, just to figure if a ship should surrender to you or not. Really, this could have been done differently... not calculating EVERY ships distance, every ships strength, every ships condition, every ships state, every ships nation, blah blah blah blah, and every ships own paint job. Only needed to be concerned with YOUR ship, and if you are a better match for them. When has a ship ever surrendered to another NPC ship? I havnt seen that happen, so why all this calculation of each ship to each and every other ship, when only they ever surrender to you or not?
Other ships don't continue to exist in the world, and morale doesn't change their effectiveness in battle. So, why were there not code added to simply ignore all these calculations when surrender was turned off? This is what I'm fixing.
However, I wanted to know if I am not seeing some other use that all this morale calcing is used for on NPC ships?
And btw, who is "NK".
I am not trying to be offensive on this one. I am just doing this because it is squarely related to this code, why I have the crappiest performance during sailing in Post Build Mod 12. I dont care about surrenders, and as such, all this code is doing nothing for me but make the sailing in game unplayable. So, a proper toggle, will save me much time and effort in the future commenting all this code out in each new update.