1. Dismiss Notice
  2. GOG.com logo

    Thanks to YOUR votes, GOG.com now sells:
    - Sea Dogs - Sea Dogs: Caribbean Tales
    - Sea Dogs: City of Abandoned Ships

    Vote now to add Pirates of the Caribbean to the list!

    Dismiss Notice
  3. Under the Crossbones Podcast

    A Pirate Podcast with Interviews
    Music, Comedy and all things Pirate!

    - Episode Guide - About - Subscribe -
    - Twitter - Facebook - iTunes - Android -
    - Youtube - Fill the Coffers -

    Dismiss Notice
  4. New Horizons logo

    Quick links for PotC: New Horizons
    - Download latest version
    - Wiki - FAQ - Report bugs here
    - ModDB profile

  5. GOF logo

    Quick links for AoP2: Gentlemen of Fortune 2
    - Downloads and info
    - Historical Immersion Supermod
    - ModDB Profile

Dismiss Notice
New to the forum?
Please take a moment to read our Welcome Message and Forum Rules.

Mod Release Build 14 Beta 4.1 WIP [Last Update: 31 August 2017]

Discussion in 'POTC Build Mod' started by Pieter Boelen, Apr 17, 2016.

  1. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,196
    Perhaps have Sylvie Bondies revert to a stock dialog after the quest is complete? Or add something so that she remembers what you have done? Compare to Elzire Ayarai, the woman in St. Pierre whom you persuade to return to church by giving her 1000 gold to show you're on the side of the angels - after you've done so, if you then visit her again she thanks you for what you've done.

    Perhaps vcskip that house permanently, so that the only person you'll see in there is Sylvie Bondies. If the quest is not active then she can just tell you to get out - again, compare to Elzire Ayarai.

    I wasn't entirely sure about that one, partly because of the changed interface and partly because there's no feedback from anyone else after installing it. I'll add it in, but will be watching for any indications that anyone is having problems with the shipyard...
     
  2. pedrwyth

    pedrwyth Privateer Storm Modder

    Joined:
    Jan 8, 2015
    Messages:
    616
    Gender:
    Male
    Understood - I appreciate it is difficult to make the call to move from "fix in progress" without positive feedback and always a risk that later it proves to have altered/broken something else so remains a strong suspect in further bug reports.
     
  3. Jack Rackham

    Jack Rackham HoO Team Member Quest Writer Storm Modder

    Joined:
    Jul 5, 2004
    Messages:
    3,275
    Gender:
    Male
    Occupation:
    math teacher
    Location:
    Sund, Ramsjö, Sweden
    Yes it works ok even if it's not as it "should" be done. I have many such cases in my quest things.
    If they hadn't worked in the first place I should have abandoned that style years ago.
     
  4. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,196
    Here's what I have now.

    Added from last time:
    • @LarryHookins fix for crash when saving game
    • @pedrwyth fix for shipyard interface cargo inclusion problems and upgrade inclusion problems
    • @Jack Rackham "Woodes Rogers" update (version number set back to 28th July version, may need to be changed as some of the updates require new savegame)
    The latest version of the "Sabine Matton" sidequest will go in when it has been finalised. Apart from that, it's pretty well ready to go...

    Update: "Sabine Matton" update now included...
     

    Attached Files:

    Last edited: Nov 16, 2016
  5. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,363
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Please, please, PLEASE stop using that construct.
    And even more please, start rewriting the ones that are already there to something else.

    I tested it once and they don't work how I would expect, nor does it do anything else that is in any way useful.
    It doesn't do anything that a regular "if-else" statement doesn't do; it just looks far more confusing to anyone who tries to understand how it works.
    So really there is no advantage to it.

    The PotC code doesn't know the "elseif" statement, so you're not getting that behaviour if that's what you're after.
    If you really want an if with more than 2 cases, then "switch" is the one you need.
    Or created nested if-statements, though I'd personally avoid those simply because they're annoying to write and understand.

    Most of the time though, I think you could probably suffice with just having consecutive if-statements without any 'else' to go with them.
    That is pretty much exactly what it does already; any 'else' after the first one serves no purpose.
     
  6. Jack Rackham

    Jack Rackham HoO Team Member Quest Writer Storm Modder

    Joined:
    Jul 5, 2004
    Messages:
    3,275
    Gender:
    Male
    Occupation:
    math teacher
    Location:
    Sund, Ramsjö, Sweden
    Ok I'll rewrite this one.
     
    Pieter Boelen likes this.
  7. Jack Rackham

    Jack Rackham HoO Team Member Quest Writer Storm Modder

    Joined:
    Jul 5, 2004
    Messages:
    3,275
    Gender:
    Male
    Occupation:
    math teacher
    Location:
    Sund, Ramsjö, Sweden
    Here. It's tested and works.
     

    Attached Files:

    • sound.c
      File size:
      41.4 KB
      Views:
      33
  8. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,196
    ANSEL likes this.
  9. Levis

    Levis Find(Rum) = false; Staff Member Programmer Creative Support Storm Modder

    Joined:
    Oct 6, 2013
    Messages:
    6,609
    Gender:
    Male
    Occupation:
    ICT
    Location:
    University Twente (Netherlands)
    it's going to be hard, you might want to include the captain generation in it because that also fixes some problems. I had to rewrite it to actually fix some of the problems.
    Thanks for doing this. I will try to make sure to have a new collection of "everything" this weekend so we can at least get everyone back on the same version.
     
  10. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,363
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Aren't there still some new bugs that can be traced to that? I think most of the "performance issues" being mentioned are actually "the game erroring out".
    I'd suggest ensuring that system is 100% (or 99%) OK before adding it to a "fixes only" archive.
     
  11. Levis

    Levis Find(Rum) = false; Staff Member Programmer Creative Support Storm Modder

    Joined:
    Oct 6, 2013
    Messages:
    6,609
    Gender:
    Male
    Occupation:
    ICT
    Location:
    University Twente (Netherlands)
    true, that's my goal for the next few days(/weeks) to iron it out.
    Then we can start comparing the version of @Grey Roger and me and slowly move things to his version and test it again.
    Maybe this is finally the point where we can have a "release" version and "experimental" version.
     
    Pieter Boelen likes this.
  12. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,363
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    That would make me very happy! :woot
     
    Levis likes this.
  13. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,196
    Mine is supposed to be the basis for the "release" version. It lacks all the experimental stuff such as the new captain generation code, weapons stats and prices, and winds. Apart from outright bug fixes (hopefully I didn't include a fix for an experimental item by mistake), the only new things are those which should not affect general gameplay, e.g. storyline and sidequest updates.

    I would recommend not moving any of the experimental code to this version until it's been used for a new release. Otherwise the whole exercise was pointless...
     
    Levis likes this.
  14. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,363
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    I should require only another 2 weekends to get my sailboat to her destination port. After that, it is my hope that things will quiet down on my end.
    So if you have some general idea about whether your "fixes only" ZIP is indeed OK by that time, I'll WinMerge it with my own game version and post it as new "official" Beta 4.1 WIP EXE.

    Very, VERY much agreed! :onya

    We should be able to have a new, stable EXE before the end of the month. And @Levis can continue developing/fixing his "new content archive" at the same time.
    Once the new EXE is available, we'd need two groups of people: One that tests the "fixes" version and another that tests the "experimental" one.
    Then anything in "experimental" that is confirmed OK, can be moved into "fixes" for the next version.
     
    Grey Roger and Levis like this.
  15. Levis

    Levis Find(Rum) = false; Staff Member Programmer Creative Support Storm Modder

    Joined:
    Oct 6, 2013
    Messages:
    6,609
    Gender:
    Male
    Occupation:
    ICT
    Location:
    University Twente (Netherlands)
    okay guys sorry I've got a new laptop and potc doesn't want to cooperate with me so I need a few more days to figure out what is going wrong.
    Can I ask all modders to post stuff they still have in the topic we have for it so saturday I can finally make a new archive?
     
  16. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,363
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Opening post EXE updated
    Depending on which game version you were running before:
    New Game is either ENFORCED or RECOMMENDED!

    This version comes with MASSIVE THANKS to @Grey Roger, without whom it would not have been possible this "soon"! :bow
    As he says:
    For more details, refer to: Fix in Progress - Post 28th July fixes | PiratesAhoy!

    EDIT: I tested this Installer EXE and it appears to work like it should, both on the Unmodded Game and the previous 28 July 2016 version.
    It *MAY* also work on the gazillion different versions that came afterwards, but I cannot make any guarantees on that.
    If you can afford to, I recommend making a clean install to rule out any potential incompatibilities.

    Contains the following changes:
    - New Features:
    . New playable characters added: Teresa Moreno (Spanish Freedom Fighter) and Bohdan Aleskeevich Voronov (Russian Cossack) by @Grey Roger
    . Baker Rifle added by @Jack Rackham and @Tingyun
    . Loanshark added to Grand Turk by @Jack Rackham
    . All female characters now support sitting by @Grey Roger
    . Extra chests added to captain's cabins by @Jack Rackham
    . Improvements to shipyard interface "acquired status" by @pedwryth
    - Gameplay/Balancing Updates:
    . Boarding Soldier Weapons Mod disabled by @Grey Roger
    . Boarding skill decrease for surrendered captains disabled by @Tingyun
    . Assigning of skill bonuses made nation-dependent by @Levis
    . Governor Ship Hunting quests increase in difficulty for Privateers/Naval Officers by me
    - Code Updates:
    . Capture Colonies nation relation consequences brought in line with ships by me
    . Additional support added for translations by @Grey Roger and me
    . Rumour texts updated by @Tingyun
    . Levelling performance improved by @Levis
    . Skill "stack" code simplified and corrected by @Levis, @Jack Rackham and me
    . Default heading for "setting sail" corrected for many islands by @LarryHookins
    . Quest item swap function added by @Grey Roger
    . Support added for specific navy/merchant character flags by @Grey Roger
    - Bug Fixes:
    . Reputation discrepancy fixed by @Grey Roger
    . Pricing for buying/selling ships with and without upgrades fixed by @pedrwyth
    . Trade quests to departure port prevented by me
    . Repeated "Relation Books" prevented by @Grey Roger and me
    . Meaningless system.log entries for missing textures fixed by @pedrwyth
    . Fast Travel to player ship fixed if companions are present by @Levis
    . Ensure prisoners are removed when appropriate by me
    . Potential CTD due to cargo overup fixed by @Levis
    . Navy address title fixed for NPCs by @Grey Roger
    . Perks assignment for player party officers fixed by @Levis
    . Missing character nationalities added by @Grey Roger
    . Missing Jamaica soldier restored by @Grey Roger
    . Coastal Guards dialog corrected by @Levis
    . Errors with saving fixed by @LarryHookins
    . Icon display size code corrected by @LarryHookins
    . Spyglass auto-equip in store code corrected by me
    . Nation Relation interface "change flag" functionality corrected by @Levis
    . Officer types and boarding crew types fixed by @Levis
    . Cannon transfer interface between ships fixed by @pedrwyth
    . Goods and Crew transfer interfaces fixed for companion ships by @pedrwyth
    . Tomwhawk code corrected by @Jack Rackham and me
    . Opium code reversed and corrected by @Levis
    . Quest ship swap function fixed by @Grey Roger
    . Hoist Flag code potentially failing fixed by @Grey Roger and me
    . Missing music in Personal towns fixed by @Cassadar
    . Trade Quests to same island prevented by me
    . Consistency fixed for store and shipyard cargo goods prices by @pedrwyth
    - Storyline Updates:
    . Sidequests:
    > Rys Bloom sidequest extended by @Grey Roger
    > Sabine Matton sidequest fixed and improved by @pedrwyth and @Talisman
    > First Contact sidequest Flying Dutchman always hostile by @Grey Roger
    > Sinking the Vogelstruijs quest code smoothed up by me
    > Sinking the Vogelstruijs Barend Hesselink more formidable enemy by @Grey Roger
    > Sinking the Vogelstruys sidequest tie-in with Smuggling removed by @Grey Roger
    > Hard Larbours of an Assassin sidequest can be started again if initially refused by me, fixed by @Grey Roger
    > Strange Things Going on in the Archipelago, ending improved by @Grey Roger
    > Church Protection sidequest code cleaned up so it completes only once by me
    > Help the Lady potential quest error fixed by @Grey Roger
    > Artois Voysey sidequest potential quest lock fixed by @Grey Roger
    > Edgar Attwood sidequest potential error fixed by @Grey Roger
    > Nigel Blythe sidequest Ethilrede Claar ship corrected for periods mod by @Grey Roger
    . Tutorial:
    > Stormy Start potentially permanently lost ship fixed by @Jack Rackham
    > Locked Cabin Icon removed after tutorial completes by @pedrwyth
    . Standard storyline:
    > Code improved by @Grey Roger
    . Ardent storyline:
    > Quest extension including wedding, convoy strike and aftermath added by @Grey Roger
    . Assassin storyline:
    > Sidequests restored and incompatibilities fixed by @Grey Roger
    . Free Play storyline:
    > Naval Officer explanation added by @Grey Roger
    . Hornblower storyline:
    > Various potential errors fixed by @Grey Roger
    . Woodes Rogers storyline:
    > More new WIP content added by @Jack Rackham
    - Model and Texture Updates:
    . Swedish East Indiaman high-detail custom model added by @philipjn and @Armada
    . Milady de Winter and Teresa Moreno custom character skins added by @Grey Roger
     
    Last edited: Jan 8, 2017
    Levis, Peter Pampher, A.H and 2 others like this.
  17. salonikasurf

    salonikasurf Freebooter Storm Modder

    Joined:
    Dec 26, 2008
    Messages:
    293
    Gender:
    Male
    Occupation:
    Engineer
    Location:
    Hay Point Australia
    :bowThanks so much Pieter and everyone who has helped in this update.
    Seems like we are getting a good start for the year. I have downloaded and will test as soon as possible.
    :cheers
     
    Pieter Boelen likes this.
  18. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,196
    Minor correction: although Teresa Moreno is Spanish in the "Sharpe" series, she's Portuguese in the game. It just works better within the game given that she has to be friendly to her homeland and hostile to France.

    Thanks for the new installer! Perfectly timed, too - a new version for a new year. :onya
     
    Pieter Boelen likes this.
  19. Carl

    Carl Powder Monkey

    Joined:
    Feb 9, 2015
    Messages:
    41
    Gender:
    Male
    Ah, just found the new exe-update... :cool:

    Time to say thank you all for the work, It´s just fantastic and one of the best games I know (if you consider New Horizons a full game like I do). I definately like all the improvements related to the character and skill management, especially it is much more obvious, how things work here.
    I wish you good winds all time, and the same for your work on Hearts Of Oak! :ahoy
     
    Pieter Boelen likes this.
  20. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,196

Share This Page