• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Anonymous codechanges

C

CouchcaptainCharles

COO (Chief Oddity Officer)
Storm Modder
Pirate Legend
Sorry, I have to drag this one into the public, as it is not the first of such incidents:

<!--quoteo--><div class='quotetop'>QUOTE</div><div class='quotemain'><!--quotec-->Bug Tracker report 0000187: Ctd in saint martin
Description: i had a CTD when i wanted to sleep in the tavern hall of saint martin <!--QuoteEnd--></div><!--QuoteEEnd-->

The innkeepers on St. Martin and Antigua are randomly generated and all use the Enc_inn.c dialogfile. I wrote that file on Mar11 . That file worked.

The Enc_inn.c file in the latest B13 has the date 17Jun and has the aforementioned fatal bug. It is certainly not the code that I wrote, but whoever changed it didn't bother to explain or comment his changes. Or test them...

So does anyone know what happened here and why?

I offer my original file as bugfix. If there is a reason why it should be changed tell me. I am always open to suggestions, and I am certainly not that vain that I would keep anyone from improving my often crude work.

But you do nobody -least at all yourself- any good if you change other people's code without consultation. There is always a reason why I write my mods the way they are, and if you don't know that reasoning you can't change them without risking havoc <img src="style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />

pirate_kk wrote that he is about to rewrite the St. Martin characters because of this bug. A lot of probably unneccessary labor that could have been avoided with a bit more care and communication.
 
CCC: sorry to see something like that happen. The only person who would know for sure where the changes came from is Pieter.

I can't speculate on who might have made the change. I wasn't here until later in that period. And as far as I know, everyone who has changed something has put their name or initials on the changes.

Hook
 
I checked out the file and I know what happened. There have been two changes, both done by Maximus. The first is the translating of the dialog, the second is the addition of a 24 hour wait period. I think this bug is caused by the 24 hour wait period. Beats my why. The 24 hour wait period works fine for the Oxbay tavern owner last time I checked. Perhaps the problem lies with te roomwait? The Saint Martin inns don't have rooms, do they? <img src="style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />

Pirate_KK already made the changes to Saint Martin now. There have been plenty of people who were confused with the taverns and stores on Saint Martin. They didn't understand why there sometimes was an owner and sometimes not. And why there would suddenly be enemies in there. I tried to explain them, but most people wanted it changed nonetheless. Perhaps we could add a toggle on whether Pirate_KK's regular code or your code should be used?
 
On no, never mind. I am not keen on having MY version in the Build. I only tried to filled the void that was there, and I tried to add a bit of variaton. But maybe those which are still faithful to PotC are so accustomed to the old ways that any variation causes confusion.

The only thing that matters is that we finally get a stable Build13. I am quite willing to sacrifice any of my mods if that helps us to reach an end point.

(I can always reinstall my version on my private installation later <img src="style_emoticons/<#EMO_DIR#>/icon_mrgreen1.gif" style="vertical-align:middle" emoid=":cheeky" border="0" alt="icon_mrgreen1.gif" /> )
 
I personally liked your version. I suppose we can keep it as-is for Build 13, then see if there's anything we can do for Build 13.1. I don't want to sacrifice your mods myself. I have gone to quite some lengths to make sure that your mods would remain in use and working properly. For example, major changes were done to corpsemodes with the result that the Maltese Knight Abbey didn't work as intended anymore, so I had to fix that. But thankfully it IS working now again. <img src="style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />
 
<!--quoteo(post=166187:date=Oct 7 2006, 10:06 PM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Oct 7 2006, 10:06 PM) [snapback]166187[/snapback]</div><div class='quotemain'><!--quotec-->
Sorry, I have to drag this one into the public, as it is not the first of such incidents:

<!--quoteo--><div class='quotetop'>QUOTE</div><div class='quotemain'><!--quotec-->Bug Tracker report 0000187: Ctd in saint martin
Description: i had a CTD when i wanted to sleep in the tavern hall of saint martin <!--QuoteEnd--></div><!--QuoteEEnd-->

The innkeepers on St. Martin and Antigua are randomly generated and all use the Enc_inn.c dialogfile. I wrote that file on Mar11 . That file worked.

The Enc_inn.c file in the latest B13 has the date 17Jun and has the aforementioned fatal bug. It is certainly not the code that I wrote, but whoever changed it didn't bother to explain or comment his changes. Or test them...

edit...
<!--QuoteEnd--></div><!--QuoteEEnd-->

Aye i can sympathise with you on that one sir! it reminds me of when the CTP2 modders finaly got the source code for that game(Call To Power II), but due to potential legal difficulties it had to have all comments stripped(there were some libelous remarks about the Civ game etc hidden in them). So the Modders recieved access to a game with over a million lines of C++ and no comments!! It slowed the whole process down dramaticaly to say the least.

Still i do remember you of old, when i was last hanging around here under a different name(a welsh pirate also, lesser known i think than Bartholomew Roberts(aka Black bart)?) i've forgotten, from a few years back; and all i can say is that it was a pleasure to have you around, so i hope you can overlook these annoyances and stick around for many a more virtual rum with us here <img src="style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" />

On a selfish note i'm very much looking forward to picking your brains on the possible port-to-port sailing mod thing that we've talked on before <img src="style_emoticons/<#EMO_DIR#>/biggrin.gif" style="vertical-align:middle" emoid=":D" border="0" alt="biggrin.gif" />
 
(spam :p)wow did my post completly get to here
i hope you guys can fix it
 
You must log in or register to reply here.
Back
Top