Good catch.Pirates shouldn't matter. In one version of "LAi_boarding.c" at least, soldier weapons are skipped if the nation is "PIRATE". Pirates shouldn't be using standard weapons, they use whatever they stole from someone else. But if they do use standard weapons, the Dragon's Head is a rare, powerful sword which you can get three ways. You can join the Brethren of the Coast and be promoted to level 3. You can take it from the dead hands of one or two captains. Or now you can just kill any regular pirate.
Indeed Pirate boarding crews won't pass through this function anyway, so it probably doesn't matter.
But your suggestion does sound better.
Your alternate is fine by me.Likewise, the Crab Claw broadsword is described in "initItems.c" as "rare+'fantasy' blade" and in "ItemsDescribe.txt" as "Ancient and rare". This is why I didn't suggest it as suitable for a general Portuguese weapon.
Mainly just to distinguish between the two periods. Otherwise it'd be a bit samey-samey.Why give Spain the more powerful tizona in earlier periods and the light tizona later? It's available in all periods, so you could use it for all periods.
But either way can work, so whatever you prefer.
I always understood Musketoons are basically intended as "boarding-purpose version of the musket". So that's why I figured it'd make sense to put it to use there.Having musketoons as general issue firearms is perhaps not a good idea. The guy in front is going to be engaged in close combat pretty quickly, which means it's the guy at the back who will fire his musketoon, much to the annoyance of the guy in front. Also, firearms in general are now more dangerous due to the reduced effect of armour on firearms, so giving the opposition area effect weapons as standard is likely to make boarding much nastier. Perhaps use "pistol2" (duelling pistol, available in all periods) for early times and "pistol8" (brace of flintlock pistols) for later. Besides, the opposition don't always get to use their guns before they are in close combat, so giving them good guns will either make boarding too nasty or give the player a lot of free guns if he wins the sword fights.
While you're right that the "area damage" will definitely cause some serious mayhem, I wonder if there might not be an alternate solution.
For example, ensuring every character in the boarding starts on his own side so that you don't begin already in a close quarters situation.
So if at all possible, I would like to use the musketoons.
But for the time being, it may be more wise to stick with your suggested alternate instead, so that's what I'll do.
I'll leave the musketoon line in place, but out-commented, just in case ever we can make use of it as it was meant to.