Fixed Shore Crewmembers: Soldier Patrols Hostile when they Shouldn't Be

[Jason]

Playing the March 13 version with a French LOM.

 

[Pieter Boelen]

Playing the March 13 version with a French LOM.

What random soldiers? You probably remember what you're referring to, but I'm afraid I don't....

Savegame, screenshots and log files are welcome as usual.

 

[Pieter Boelen]

@Jason: Were you referring to the soldiers deciding to attack the player while in town? Or in a tavern?
Or is it between the soldiers and the citizens this time? I need every and all details that you can possibly provide.

 

[Jason]

What random soldiers? You probably remember what you're referring to, but I'm afraid I don't....

Savegame, screenshots and log files are welcome as usual.

On Martinique and only on Martinique French soldiers randomly attack my character when I change scenes. Not always but on you land and it starts it continues until you leave the island. you can avoid it by going back to the previous location and entering again but sometimes you must do that three or four times to get them to calm down. Occasionally one of the soldiers is immortal. I will look through my saves and see if I can find one where this happens.

 

[Pieter Boelen]

Do you use Shore Crewmembers at all?
Are they the regular town guards who attack?
A savegame would be welcome for sure.

Just in case, you could press F11 and see if that makes any difference at all.
It probably won't, but it's worth a try.

 

[Pieter Boelen]

Do you use Shore Crewmembers at all?
Are they the regular town guards who attack?
A savegame should be useful for sure.

Just in case, you could press F11 and see if that makes any difference at all.
It probably won't, but it's worth a try.

 

[Jason]

Do you use Shore Crewmembers at all?
Are they the regular town guards who attack?
A savegame should be useful for sure.

Just in case, you could press F11 and see if that makes any difference at all.
It probably won't, but it's worth a try.

I do use shore crew, but I didn't have any when this happened. Yes, sometimes, but often they just appear.

 

[Pieter Boelen]

If the guards just appear, they must be something else than regular town guards.
I'll be curious to check your save game.

 

[Jason]

If the guards just appear, they must be something else than regular town guards.
I'll be curious to check your save game.

If you exit the tavern, you should get attacked.

 

[Pieter Boelen]

Thanks. Will try it soon. Probably next week.

 

[Pieter Boelen]

You're right, @Jason. This IS a weird one.

When I exited the tavern, everything was peaceful and quiet.
But when I exited again, there was a "SOLDIER PATROL !!!" consisting of apparently one immortal French soldier who hates you.
And as soon as you get into a fight with him, the rest of the town guards get upset too.
That.... definitely shouldn't be happening.

 

[Pieter Boelen]

Extract attached to PROGRAM\LandEncounters to fix. I think I found the error.
The problem was with these lines:

 if(GetNationRelation2MainCharacter(nation) == RELATION_FRIEND)
 {
 LAi_group_SetRelation(GetSoldiersGroup(nation), LAI_GROUP_PLAYER, LAI_GROUP_ENEMY);
 }
 else
 {
 LAi_group_SetRelation(GetSoldiersGroup(nation), LAI_GROUP_PLAYER, LAI_GROUP_NEUTRAL);
 }

They should be this instead:

 if(GetNationRelation2MainCharacter(nation) == RELATION_FRIEND)
 {
 LAi_group_SetRelation(GetSoldiersGroup(nation), LAI_GROUP_MONSTERS, LAI_GROUP_ENEMY);
 }
 else
 {
 LAi_group_SetRelation(GetSoldiersGroup(nation), LAI_GROUP_MONSTERS, LAI_GROUP_NEUTRAL);
 }

That must have gotten swapped around not too long ago, but I'm not sure how or when.

It was meant to have the soldier patrol HELP you AGAINST enemies.
But it ended up doing the very opposite thing.

It was a definite mistake that made zero sense. With this, it should be back to normal.
Thanks for catching, @Jason!

 

[Pieter Boelen]

This now corrected in here:
Mod Release - Build 14 Beta 4 Internal WIP For Testing | Page 14 | PiratesAhoy!