• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Fixed Ship's Log Update Sound Too Frequent

A.H

A.H

Privateer
Not sure if it's included in recent updates, but the ship log keeps ringing every 30 seconds.. as if a new update is happening on questbook but for shiplog.. anyway to turn off this notification? i can still hear bells ringing in my ears :fiddler
 
A.H said:
Not sure if it's included in recent updates, but the ship log keeps ringing every 30 seconds.. as if a new update is happening on questbook but for shiplog.. anyway to turn off this notification? i can still hear bells ringing in my ears :fiddler
Click to expand...
I added sound and on-screen notification for Ship's Log updates to make those more obvious.
Why do you have an update every 30 seconds though? What is actually being logged?
 
For ship log ringing.. not 100% sure since i saw it once.. but i think it is the same news that you ask a tavernkeeper on the world news.. and when i repair my ship (5 days or so), a lot of shiplog ringing happens in a 1 second time frame *ring ring ring*.. if you get what I mean.
 

Attachments

  • fght.jpg
    fght.jpg
    87.6 KB · Views: 88
A.H said:
- For ship log ringing.. not 100% sure since i saw it once.. but i think it is the same news that you ask a tavernkeeper on the world news.. and when i repair my ship (5 days or so), a lot of shiplog ringing happens in a 1 second time frame *ring ring ring*.. if you get what I mean.
Click to expand...
Of course the Tavern News goes into the Ship's Log. But that is only once in a while.
I'd like to know the exact situations where it is really overkill.

Maybe we should have the sound only for specific catagories of news?
 
It happens regularly while sailing along and is annoying as the ships log is not updated or anything is changed as far as I can tell.
 
The sound gets triggered in the 'WriteNewLogEntry' function, but ONLY if there is a new entry, not if it is updating an existing one.

So if there is a sound, there MUST be an accompanying update as well.
In the Ship's Log, NOT the Questbook.

There are five categories of updates: "General", "Battle", "Ship", "Personal", "Notes".
How about we limit the sound to only the ones marked in bold there?

In PROGRAM\sulan_shipslog.c find:
Code: 
   // PB: Sound and on-screen effects -->
   Log_SetStringToLog(XI_ConvertString("Ship Log Update"));
   AddMsgToCharacter(pchar,MSGICON_LOGBOOK);
   PlaySound("INTERFACE\notebook_01.wav");
   // PB: Sound and on-screen effects <--
Replace with:
Code: 
   // PB: Sound and on-screen effects -->
   if (logCategory == "General" || logCategory == "Personal")
   {
     Log_SetStringToLog(XI_ConvertString("Ship Log Update"));
     AddMsgToCharacter(pchar,MSGICON_LOGBOOK);
     PlaySound("INTERFACE\notebook_01.wav");
   }
   // PB: Sound and on-screen effects <--
Would that be better?
 
The reduced audible/visual updates for the Ship's Log have been in the mod for three weeks now.
Has anyone noticed it happening too often anymore?
 
I still notice on-screen alerts accompanied by the bell informing me that the ship's log has been updated. A check of the ship's log indicates that nothing has been added. (I know the difference between ship's log and questbook, but I checked the questbook as well and it hadn't been updated either.)
 
Grey Roger said:
I still notice on-screen alerts accompanied by the bell informing me that the ship's log has been updated. A check of the ship's log indicates that nothing has been added. (I know the difference between ship's log and questbook, but I checked the questbook as well and it hadn't been updated either.)
Click to expand...
I was afraid of that; I seemed to be noticing it as well, but didn't do a proper test.

Anyway, issue reopened; I'll look into it. Thanks for reporting. :doff

Do you know sort-of in which instances this occurs? Then I'll know where to focus my efforts.
 
In my case, direct-sailing from Havana to Santiago, not doing anything on the way. The storyline has a timer running which, when it expires, will trigger a questbook update, but that isn't due until 14 days after game start, and even with a less than optimal wind it doesn't take me that long to get to Santiago. (Because if the wind is being really unco-operative I go to worldmap. :D) On day 14 the questbook update does happen and is correctly announced as a questbook update.

It may be that the sort of updates which you only see when you check at the tavern for news are happening in the background and triggering the alerts, but because I haven't been to the tavern to check news, they don't appear in the questbook.
 
Grey Roger said:
In my case, direct-sailing from Havana to Santiago, not doing anything on the way.
Click to expand...
Is it always at midnight or is it just at random times?

Grey Roger said:
It may be that the sort of updates which you only see when you check at the tavern for news are happening in the background and triggering the alerts, but because I haven't been to the tavern to check news, they don't appear in the questbook.
Click to expand...
Might be. If so, I'll need to detect that it is a TAVERN update that doesn't get written to your Ship's Log and then skip the sound for those.
 
@Grey Roger: Another question that just occurred to me.... Does this issue start immediately on a New Game or does it show up later?
If later, could you post a savegame that is affected by it?
 
Later, when I'm at sea. Or possibly after a day has passed. Ardent has a busy first day so a lot happens before I get to sea and the day changes, so it's a little way into the game before anything which triggers the ship's log non-update happens. ;)
 
Grey Roger said:
It may be that the sort of updates which you only see when you check at the tavern for news are happening in the background and triggering the alerts, but because I haven't been to the tavern to check news, they don't appear in the questbook.
Click to expand...
Looking at the code again, that theory seems VERY likely.
So in PROGRAM\sulan_shipslog.c find:
Code: 
  // PB: Sound and on-screen effects -->
   if (logCategory == "General" || logCategory == "Personal")
   {
     Log_SetStringToLog(XI_ConvertString("Ship Log Update"));
     AddMsgToCharacter(pchar,MSGICON_LOGBOOK);
     PlaySound("INTERFACE\notebook_01.wav");
   }
   // PB: Sound and on-screen effects <--
Replace with:
Code: 
  // PB: Sound and on-screen effects -->
   if (bVisible)
   {
     if (logCategory == "General" || logCategory == "Personal")
     {
       Log_SetStringToLog(XI_ConvertString("Ship Log Update"));
       AddMsgToCharacter(pchar,MSGICON_LOGBOOK);
       PlaySound("INTERFACE\notebook_01.wav");
     }
   }
   // PB: Sound and on-screen effects <--

If that was indeed the reason, this should probably put an end to it. :cheeky
 
Apparently so. I loaded up a savegame from where I was just about to leave Havana, direct-sailed round to Santiago as usual, and for the first time did not get any pings or messages about ship's log getting updates which didn't appear. Checking in at Santiago tavern showed that there had been a few news items, so if that's what was causing the spurious update reports before, they didn't do it this time.
 
Grey Roger said:
Apparently so. I loaded up a savegame from where I was just about to leave Havana, direct-sailed round to Santiago as usual, and for the first time did not get any pings or messages about ship's log getting updates which didn't appear. Checking in at Santiago tavern showed that there had been a few news items, so if that's what was causing the spurious update reports before, they didn't do it this time.
Click to expand...
I reckon this one is "Fixed" then. Thanks for your help on it! :cheers
 
You must log in or register to reply here.
Back
Top