Fixed Crash when asking the tavernkeeper about escort ship mission

[HellSailor]

Basically it's what it says in the title... I tried to have an escort ship mission, but when the tavernkeeper said that there was one person interested, after the dialogue, it gets frozen. I waited one minute and nothing changed.

Does anyone know about this issue before? If there's a thread talking about this, I'm sorry.

Btw, I have now a Windows 7 with 64-bits and a proccessor AMD Atheleon A10-7870K. Not sure if this is important, so I'll put it here.

Tested with the 28th December Version of Beta 4 WIP.

EDIT: Uploaded save so you can see what happens to me.

 

[Pieter Boelen]

I can imagine it hanging there for a bit. But a full minute of hanging is quite silly.

The only real reason I can think of is if your nation relations prevent ANY valid destinations and it keeps searching in an infinite loop.
But it shouldn't do that; that's why there is a "default destination".

Do you happen to have a savegame in front of the offending tavern owner? Then I can see if I can replicate it.

 

[HellSailor]

I can imagine it hanging there for a bit. But a full minute of hanging is quite silly.

The only real reason I can think of is if your nation relations prevent ANY valid destinations and it keeps searching in an infinite loop.
But it shouldn't do that; that's why there is a "default destination".

Do you happen to have a savegame in front of the offending tavern owner? Then I can see if I can replicate it.

Yup, I have just uploaded it. Bit of an update. Edited the first post.

 

[Pieter Boelen]

Confirmed. Probably related to you being hostile to everyone except Portugal.
Still, that shouldn't cause this issue, so I'm on the case....

 

[Pieter Boelen]

The problem was that you are Portuguese. Portugal is hostile to EVERYONE and also has only one town.
Which means that effectively the only valid destination was the town where you're already at.
Even the "default destination" wouldn't save you, because that is on the same island where you already are.
So you managed to trigger quite a nice situation there!

Anyway, I have tweaked the logic a bit in the attached file; extract to PROGRAM\QUESTS to try it.
Now Escort Quests can ALWAYS go to Pirate towns and also don't take into account the nations you personally are hostile to either.

This means that you can get sent to dangerous places, but you always have the chance to decline the quest.
Some Pirate destinations also do not show up on the map, but the dialog and questbook entries tell you where to go.

So I reckon this should help quite a bit. Will make for some more variety in destinations too.

 

[HellSailor]

@Pieter Boelen , news about this bug: No longer appears to happen! The cause about why in my save I couldn't do that is because maybe I didn't repair my ship in the dockyard (Doing the tutorial), and so, something bizarre happened to it. Maybe I can't do escort ship missions unless you go pass some days.

Recently in my campaign Portugal and Holland make peace, so I went to sent a cargo to Aruba. Then, I tried again the escort ship mission in the Tavern of Oranjestad, and it didn't crashed or get frozen.

 

[Pieter Boelen]

Recently in my campaign Portugal and Holland make peace, so I went to sent a cargo to Aruba.

That would explain why the problem disappeared.
Anyway, please see my post above.

 

[HellSailor]

I saw it. Will give a try in that save and see what is the result. Better to give you the save.

 

[HellSailor]

Problem fixed. Here's a screenshot of the same save of the first post. Now it shows me a destiny which is dangerous to me. In this case, is Pirate Fort, on Bonaire. It didn't get crashed or frozen.

 

[Pieter Boelen]

I made some extra changes now so that the dialog will mention the correct destination name all the time.
So when you have to go to a beach, you'll not only know from the Questbook, but because he actually SAYS so too.

 

[Hylie Pistof]

OT

A 7870k? Those have a good reputation as a midrange APU and should do well with POTC.

 

[HellSailor]

Heads up! This problem is back in 6th February Version. My game crashes whenever I try to do an escort quest on my new campaign.
I did a new free play storyline with Stormy Start, Personal Relation (Not serving to any country) and Wary to all nations (Including the pirates), because of chosing Rebel type class at the start.
Here you have a save in which you can test it. Also I will give you error logs and other stuff.

 

[Pieter Boelen]

Heads up! This problem is back in 6th February Version. My game crashes whenever I try to do an escort quest on my new campaign.
I did a new free play storyline with Stormy Start, Personal Relation (Not serving to any country) and Wary to all nations (Including the pirates), because of chosing Rebel type class at the start.
Here you have a save in which you can test it. Also I will give you error logs and other stuff.

I did a quick test on your savegame and it didn't crash for me. However, I do believe you and I think I know what is going on.
Probably the game decided there should be an enemy at the destination and since you don't HAVE enemies, the game gets into an endless loop.

For starters, I am making some changes so that a Personal Rebel will be hostile to a RANDOM nation.
Because otherwise you're pretending to have rebelled against yourself, which makes no sense.
Alternative would be to have you hostile to the Pirates by default, but that would make for a hard tutorial as you start at the Pirate Settlement.

I'll also see if I can prevent that endless loop.

 

[Pieter Boelen]

@HellSailor: I rewrote a function to return PIRATE as hostile nation if there are none to be found.
That should prevent infinite loops and therefore should also prevent the game crashing.
Extract dialog.zip to your PROGRAM folder.

That being said, I cannot promise that there won't be more strange stuff later on because you have no enemies.
The game basically assumes that there MUST be enemies of some sort out there, so as per the next update, a "Personal Rebel" will get a random enemy.

 

[HellSailor]

That has fixed the problem