• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Search results

  1. jsv

    Fixed Remove unnecessary code duplication in SBGetShoreLeavePay

    Yep, in the last line of the quoted part.
  2. jsv

    Cannot Confirm 3D Sailing Mode: Game Randomly Locks Up, Have to Force Quit

    @pedrwyth, while you at this, can you please check if this: // clear some of group attributes for (i=0; i<MAX_SHIP_GROUPS; i++) { rGroup = Group_GetGroupByIndex(i); if (CheckAttribute(rGroup, "AlreadyLoaded")) DeleteAttribute(rGroup, "AlreadyLoaded"); } is...
  3. jsv

    Fixed Remove unnecessary code duplication in SBGetShoreLeavePay

    I'm removing that 5 from the crew pay calculation, then. If it will turn out one can berth empty ships for free as the result, we'll rectify it elsewhere. And this is really nice: int SHORE_LEAVE_PAY_REDUCTION = 4; ... // ***** 3: WORK OUT OWN PAY AND OFFICERS' PAY ***** ...
  4. jsv

    Fixed Remove unnecessary code duplication in SBGetShoreLeavePay

    Hmm... In the berthing code: // ***** 1: WORK OUT PAY FOR CREW ***** float amCrewPaymentQ = 5 + amCrewQty*12 amCrewPaymentQ *= (1.0 - (makefloat(amLeaderShip)*makefloat(1.0+GetOfficersPerkUsing(amCaptainChar,"IronWill"))/40.0)) * (0.5 + makefloat(GetDifficulty())*0.5); if (TRACELOG...
  5. jsv

    Cannot Confirm 3D Sailing Mode: Game Randomly Locks Up, Have to Force Quit

    He did bother to add a comment. I think if he knew what's going on, the comment would be a bit more detailed. :)
  6. jsv

    Build Update Requests

    Just shoot the bastards and hire smarter ones. Why do you people insist on making a problem of everything? Well, admittedly, smart NPC bastards are in short supply... but at least ammunition is cheap. :boom:
  7. jsv

    Fixed Levelling: Sailing Skill Increases through Save/Load

    I'm pretty certain this was one of the reasons. If we are lucky, this was the only reason. ;)
  8. jsv

    Cannot Confirm 3D Sailing Mode: Game Randomly Locks Up, Have to Force Quit

    Well, as written it deletes the "AlreadyLoaded" attribute, but only when there is no such attribute. If I'm to guess, it's either supposed to do that when there is such attribute, or it has no reason to be there at all. In other words it's ether a mistakenly reversed condition or some obscure...
  9. jsv

    Fixed Levelling: Sailing Skill Increases through Save/Load

    The 'postevent' attribute was not cleared in RestoreCharacterEvents. It the case of the above quicksave there was only sailing experience stored in that attribute, but potentially... @Levis would know better, but I think all kinds of nasty surprises were possible.
  10. jsv

    Fixed Levelling: Sailing Skill Increases through Save/Load

    OK, that fixes the save/load problem. I'll do some actual playtesting on weekend to see if there is any more strangeness about sailing skill growth, but I think we can close this one as fixed.
  11. jsv

    Cannot Confirm 3D Sailing Mode: Game Randomly Locks Up, Have to Force Quit

    HUH?! indeed. No, scratch that. HUH?! is an understatement. :)
  12. jsv

    WIP Improve the Crewmembers on Shore Mod

    That code is not correct. Meaning it will be rejected by the engine. rand is a function. You call it like rand(N), N being some integer number, and it returns a random integer between 0 and N. It's like rolling N-sided die. "rand < something" makes no sense in Storm engine's language and it will...
  13. jsv

    Fixed Remove unnecessary code duplication in SBGetShoreLeavePay

    Thanks, I think I'll able to finish this myself. Either way, I'm done for today, so feel free to focus on other things.
  14. jsv

    Included in Build Improve Merchant and Navy Flags and Pennants

    I think Dutch in Early Explorers suffer from the same.
  15. jsv

    Fixed Jack Sparrow Storyline: Island "error" after reload

    From the log: Can't find island sIslandID = error We still don't have the Error Island in this game? :)
  16. jsv

    Fixed Remove unnecessary code duplication in SBGetShoreLeavePay

    I meant it wasn't applied when paying the crew on shore leave. It is applied to all officer prices (at least all that I have checked so far). It was so before my fixes and will remain so.
  17. jsv

    Fixed Remove unnecessary code duplication in SBGetShoreLeavePay

    Well, I'm getting somewhere with that officers' stuff. I hope to finish fixing this one (together with crew hire prices) tomorrow. By the way, this particular piece of code didn't seem to apply SALARY_MULTIPLIER... All my fixes so far are making things more expensive, mwa-ha-ha! :pirate07:
  18. jsv

    Fix in Progress DirectSail and WorldMap island transfer inconsistencies

    Anyway, I likely won't have time for the "debug to death" part until New Year holidays. :xmas
  19. jsv

    Fix in Progress DirectSail and WorldMap island transfer inconsistencies

    Looking at CCCDirectSail.c, I'd really like to remove all cell navigation code (when it was the last time it was used?), reorganize what is left, and then debug it do death... Although that's not the enterprise to embark on at the time when we are trying to get a relatively stable public release :)
  20. jsv

    Fixed Levelling: Sailing Skill Increases through Save/Load

    Ah, my bad. Had to set the debug variables to 2. Here we go: !!! Reload to QC_brothel (index=158) POSTINIT: state is 1 POSTINIT: restore events for Alfonso Palomo POSTINIT: restore skill XP for skill Sailing for Alfonso Palomo XP LOG: Called AddXPtoSkillsMain with Exp: 555 XP LOG: AddXP to...
Back
Top