Need Help "nosurrender" attribute and retreat

[Tingyun]

Unifying the retreat functions, some are in the morale check (where if a character has "nosurrender" marked they skip), others are elsewhere and get run for everyone. Many of these are inherently similar (ie, HP loss checks for retreat appear all over the place, some blocked by this, others not).

What is the relation of the "nosurrender" attribute and retreating? Is it just irrelevant to the question and an accident some retreat checks get blocked by it?

 

[Pieter Boelen]

That attribute is mostly set for quest ships that are meant to "fight to the death".
So they should definitely not run if they have it and, depending on the setting, should not surrender during battle nor during boarding either.

 

[Tingyun]

Got it, I'll make it prevent all retreats now, not just some. Nice part of getting everything into one function is it is easy to notice mistakes like that.

It was properly blocking surrender before, just not all retreats, so no fix needed on surrenders.

 

[Tingyun]

One more question if anyone is still around.

In the same function, the code currently uses &rCharacter and rCharacter to get values:

float HP = GetCurrentShipHP(&rCharacter);
float SP = GetSailPercent(rCharacter);

What is the significance of this? Is one safer to use?

I know they are both currently working, just curious.

 

[Pieter Boelen]

Don't think it makes a difference here.
People in the past used that in many spots where it should not be necessary.