Fixed Bug with skill boost items that require multiple of the item to work

[Jack Rackham]

I think I'm on the right path now. There's just one thing. The MAX_SKILL_INCREASE
limits the -1 luck/each cursedcoin to totally -4 luck by this line:

mod = iclamp(-MAX_SKILL_INCREASE, MAX_SKILL_INCREASE, mod);

So I want to make an exception for the cursedcoin, something like:

if(itmid == "cursedcoin")
{
mod = iclamp(-100, MAX_SKILL_INCREASE, mod); //JRH for cursed coin
}
else
{
mod = iclamp(-MAX_SKILL_INCREASE, MAX_SKILL_INCREASE, mod); // PB: Single line
}

but something's wrong with if(itmid == "cursedcoin"). Not read.
Any ideas?

 

[Jack Rackham]

Also: opium and vegetal have very high numbers on stack but no skillbonus.
Guess those == 0 if stack is a bool. Or any other purpose here @Levis?

 

[Levis]

Also: opium and vegetal have very high numbers on stack but no skillbonus.
Guess those == 0 if stack is a bool. Or any other purpose here @Levis?

Its because i tought stack was something else, they can be 0.

 

[Levis]

As far as I know my code worked. I suggest we change all items to not stack and only let the cursed coin stack. Then remove the max option all together.
What do you say @Jack Rackham ?

 

[Jack Rackham]

I suggest we change all items to not stack and only let the cursed coin stack.

Yes I've done that and changed stack to a bool. Your code works fine.

Then remove the max option all together.

It is too easy to get your skills up through items as it is.

Maybe just keep the positive max?

mod = iclamp(-100, MAX_SKILL_INCREASE, mod);

 

[Levis]

Will there ever be something which stacks positive anyway? I guess not..

 

[Jack Rackham]

Maybe not but if you got 6 items which each gives +1 leadership the MAX_SKILL_INCREASE
limits it to +4 leadership. I'll just skip the negative limit for now so > 4 cursedcoin takes effect.

 

[Jack Rackham]

Okay, here's the version with stack as a bool. @Levis code is unchanged.
Only cursedcoin stacks and has been given the -1 Luck.
MAX_SKILL_INCREASE upper limit kept but lower limit removed for cursedcoin.

 

[Levis]

Included in new update located here:
Mod Release - Build 14 Beta 4.1 WIP | PiratesAhoy!

 

[Pieter Boelen]

Sounds like some good changes here!

 

[Pieter Boelen]

@Jack Rackham, @pedrwyth and/or @Grey Roger: Do you guys reckon if items should "stack" by default?
Or should only "cursed coins" stack? I think we agreed to use this for cursed coins only, right?

 

[Pieter Boelen]

Also, I'm replacing this:

       //Levis --> fix overflowing the stack not applying any bonus
       //Check if the player has enough items
       if(qty >= sti(itm.skill.num))
       {
         //Check if bonusses stack
         if(itm.skill.stack == true)       //JRH
         {
           //they stack, so we can add the mod
           mod += sti(itm.skill.(skillName)) * qty/sti(itm.skill.num);
         }
         else
         {
           //they don't stack so just add the mod once.
           mod += sti(itm.skill.(skillName));
         }
     }
       //Levis <--

With this:

       if(sti(itm.skill.stack) == false) qty = 1;
       mod += sti(itm.skill.(skillName)) * qty; // PB: Used to end with '/sti(itm.skill.num)'

I think that still maintains the (now simplified) intention of the feature.