• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Fixed Stuck after boarding certain quest ships that trigger a reload

@pedrwyth could you tell me which files aren't included yet? Is this only the latest zip file you uploaded? It's only standard storyline right?
 
could you tell me which files aren't included yet? Is this only the latest zip file you uploaded? It's only standard storyline right?

Yes just the last zip -the earlier ones were in 9th July zip. Yes just standard storyline.

but note

GiveItem2Character(pchar, INCAS_COLLECTION);

Ah, that one will need tweaking for Beta 3.5 because I removed the #define-based item IDs.

Right well it's in case "abording_pirate_06_complete": in quests.reaction.c

where it looks like it needs to be
Code:
GiveItem2Character(pchar, "icollection");
instead in the file in the zip.

There are a couple of unused codelines that could have been removed but that's just cosmetic and there's plenty of other commented out code lying around.
 
What the hell it's only a 2 second job to remove the redundant code so this one is for the animists side quest if you want to winmerge and check the two lines removed
 

Attachments

  • quests_side.7z
    36.9 KB · Views: 158
@pedrwyth: It is correct that this line is REMOVED again, right?
Code:
      pchar.quest.abording_pirate_06.win_condition.l1 = "Character_Capture";
       pchar.quest.abording_pirate_06.win_condition.l1.character = "Pirate Captain 06";
       pchar.quest.abording_pirate_06.win_condition.l2 = "SeaEnter"; // <------------- THIS LINE ------------
       pchar.quest.abording_pirate_06.win_condition = "abording_pirate_06_complete";
 
@pedrwyth: It is correct that this line is REMOVED again, right?
Code:
      pchar.quest.abording_pirate_06.win_condition.l1 = "Character_Capture";
       pchar.quest.abording_pirate_06.win_condition.l1.character = "Pirate Captain 06";
       pchar.quest.abording_pirate_06.win_condition.l2 = "SeaEnter"; // <------------- THIS LINE ------------
       pchar.quest.abording_pirate_06.win_condition = "abording_pirate_06_complete";
Yes

This let's the boarding case proceed and the next case thus called removes the kill pirate 06 check (which death seems to happen if you capture him too) before that would execute (which if happening whilst boarded is the basic root cause of all four crash instances). The kill prate 06 being held up by the "SeaEnter" condition but with the above line in place overrode the boarding case to reload you to the beach salvaging the ship you may not have sunk.
 
This is now included in here and should be fully operational: http://www.piratesahoy.net/threads/build-14-beta-3-5-internal-wip-for-testing.24817/

@pedrwyth: Please check the code there to make sure I didn't accidentally miss out on any of your updates.

All four cases of boarding crash look fine in the latest version.

@Levis this fixes some longer term bug reports left as red/confirmed in the archive
http://www.piratesahoy.net/threads/666-hunderd-devils.21912/

http://www.piratesahoy.net/threads/cant-board-sirena.22010/

which could be altered to fixed?

I also effectively fixed this one
http://www.piratesahoy.net/threads/blacklock-not-respawning-in-strange-things-happening.22050/
previously too.
 
Not too sure if this has been reported but the part in the main story line Get details from the governor when you have to Fight Frigate sailing away from Bridgetown the game goes haywire when trying to capture it, The first time I tried I got as far as fighting the captain of the ship then I was transported to the beech then all the sea and sky was black and I could still hear myself fighting the captain, the second time same thing but this is what showed up also.

http://i696.photobucket.com/albums/vv323/leo1954au/ship_zpsssjambnj.jpg

The third time I just sank the frigate and all went well without a problem, I'm using Build 14.3. Sorry I couldn't get the insert Img to work
 
That particular ship has always needed to be sunk, not boarded, just like the last ship in the Battle of Bridgetown needs to be sunk, not boarded.
 
The thread I linked to earlier says that these bugs were already fixed months ago.
As far as I know, it was confirmed OK already. :shrug
 
Not too sure if this has been reported but the part in the main story line Get details from the governor when you have to Fight Frigate sailing away from Bridgetown the game goes haywire when trying to capture it, The first time I tried I got as far as fighting the captain of the ship then I was transported to the beech then all the sea and sky was black and I could still hear myself fighting the captain, the second time same thing but this is what showed up also.
^ Can anyone confirm that this is indeed fixed in Beta 4?
@pedrwyth, did you cover this particular example too?
 
Yes as it says in the above thread I covered the frigate with the idol sailing from Bridgetown with the other "known" cases. That was in July last year so post #65 it went into build 14 3.5 (which never made it public). I doubt if anyone other than me has checked it either then or since in beta 4 but unless the myriad of later changes has had an influence (which I doubt in these cases) it should still be fixed.
 
Yes as it says in the above thread I covered the frigate with the idol sailing from Bridgetown with the other "known" cases. That was in July last year so post #65 it went into build 14 3.5 (which never made it public). I doubt if anyone other than me has checked it either then or since in beta 4 but unless the myriad of later changes has had an influence (which I doubt in these cases) it should still be fixed.
Thanks for confirming! Back to fixed. :doff
 
Back
Top